Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2565743002: Switch to std::is_fundamental<>. (Closed)

Created:
4 years ago by Yang
Modified:
4 years ago
Reviewers:
Clemens Hammacher
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Switch to std::is_fundamental<>. Thanks for pointing this out to me! R=clemensh@chromium.org BUG=v8:5731 Committed: https://crrev.com/c9f8e23bbc50c628173fa927dff40a7303579203 Cr-Commit-Position: refs/heads/master@{#41620}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -20 lines) Patch
M src/base/macros.h View 1 chunk +0 lines, -19 lines 0 comments Download
M src/list-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
Yang
4 years ago (2016-12-09 14:19:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565743002/1
4 years ago (2016-12-09 14:21:19 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years ago (2016-12-09 14:21:20 UTC) #5
Clemens Hammacher
lgtm
4 years ago (2016-12-09 14:29:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565743002/1
4 years ago (2016-12-09 14:52:05 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 14:54:08 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-09 14:54:42 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9f8e23bbc50c628173fa927dff40a7303579203
Cr-Commit-Position: refs/heads/master@{#41620}

Powered by Google App Engine
This is Rietveld 408576698