Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 2565733002: [deoptimizer] Fix Deoptimizer::GetDeoptInfo for last entry. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
Tobias Tebbi, Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Fix Deoptimizer::GetDeoptInfo for last entry. This fixes the corner-case where the method in question failed to lookup the very last deoptimization bailout without subsequent entries within the relocation info. Also enable a test covering this. R=tebbi@chromium.org TEST=cctest/test-cpu-profiler/CollectDeoptEvents Committed: https://crrev.com/50c5ac57de4442d76434924dc8ee03d02b4e7874 Cr-Commit-Position: refs/heads/master@{#41623}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -10 lines) Patch
M src/deoptimizer.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +0 lines, -3 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Michael Starzinger
4 years ago (2016-12-09 12:42:11 UTC) #3
Jarin
lgtm. Great catch!
4 years ago (2016-12-09 14:02:35 UTC) #7
Tobias Tebbi
lgtm
4 years ago (2016-12-09 15:03:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565733002/1
4 years ago (2016-12-09 15:03:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 15:05:52 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-09 15:06:31 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/50c5ac57de4442d76434924dc8ee03d02b4e7874
Cr-Commit-Position: refs/heads/master@{#41623}

Powered by Google App Engine
This is Rietveld 408576698