android: Realign stack pointer on JNI entry.

android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248
Review-Url: https://codereview.chromium.org/2531273002
Cr-Commit-Position: refs/heads/master@{#435632}
(cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602)

R=rmcilroy@chromium.org

Committed: https://chromium.googlesource.com/chromium/src/+/a38f6d5fb4ca186b9e682cd11e1fc87d2014e00c

[rmcilroy, 2016-12-09 12:22:02]

rmcilroy@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2016-12-09 12:22:02]

LGTM

[Torne, 2016-12-09 12:26:35]

Description was changed from

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248

Review-Url: https://codereview.chromium.org/2531273002
Cr-Commit-Position: refs/heads/master@{#435632}
(cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602)
==========

to

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248

Review-Url: https://codereview.chromium.org/2531273002
Cr-Commit-Position: refs/heads/master@{#435632}
(cherry picked from commit 7be1137994eecca6c54831e4c3d3d4f934ea8602)

R=rmcilroy@chromium.org

Committed:
https://chromium.googlesource.com/chromium/src/+/a38f6d5fb4ca186b9e682cd11e1f...
==========

[Torne, 2016-12-09 12:26:37]

Committed patchset #1 (id:1) manually as
a38f6d5fb4ca186b9e682cd11e1fc87d2014e00c.