android: Realign stack pointer on JNI entry.

android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248
Committed: https://crrev.com/7be1137994eecca6c54831e4c3d3d4f934ea8602
Cr-Commit-Position: refs/heads/master@{#435632}

[Torne, 2016-11-28 14:22:16]

torne@chromium.org changed reviewers:
+ primiano@chromium.org, rmcilroy@chromium.org

[Torne, 2016-11-28 14:22:17]

I've verified that the x86 code generated has appropriate stack alignment code
with this change, but haven't actually run it. Pinging the bug to see if anyone
is able to test this.

[Primiano Tucci (use gerrit), 2016-11-28 14:39:28]

LGTM thanks

https://codereview.chromium.org/2531273002/diff/1/base/android/jni_generator/...
File base/android/jni_generator/golden_sample_for_tests_jni.h (right):

https://codereview.chromium.org/2531273002/diff/1/base/android/jni_generator/...
base/android/jni_generator/golden_sample_for_tests_jni.h:54: #if
defined(ARCH_CPU_X86)
maybe just #define ALIGN_STACK_X86 ... this once on the top and then use just a
macro here and below ?

[rmcilroy, 2016-11-28 15:21:56]

LGTM

https://codereview.chromium.org/2531273002/diff/1/base/android/jni_generator/...
File base/android/jni_generator/golden_sample_for_tests_jni.h (right):

https://codereview.chromium.org/2531273002/diff/1/base/android/jni_generator/...
base/android/jni_generator/golden_sample_for_tests_jni.h:54: #if
defined(ARCH_CPU_X86)
On 2016/11/28 14:39:28, Primiano Tucci wrote:
> maybe just #define ALIGN_STACK_X86 ... this once on the top and then use just
a
> macro here and below ?

+1

[Torne, 2016-12-01 14:42:03]

The CQ bit was checked by torne@chromium.org

[commit-bot: I haz the power, 2016-12-01 14:42:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 14:50:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 14:50:08]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Torne, 2016-12-01 14:57:02]

Bleugh, forgot that the presubmit warns because the generated golden test file
doesn't pass clang-format. Will figure out a solution ;)

[Torne, 2016-12-01 15:22:14]

Description was changed from

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

BUG=655248
==========

to

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Also, move the function attributes into a macro so that the generated
header file is less repetitive (this also makes the generator less
repetitive as a bonus).


BUG=655248
==========

[Torne, 2016-12-01 15:22:23]

Description was changed from

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Also, move the function attributes into a macro so that the generated
header file is less repetitive (this also makes the generator less
repetitive as a bonus).


BUG=655248
==========

to

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Also, move the function attributes into a macro so that the generated
header file is less repetitive (this also makes the generator less
repetitive as a bonus).

BUG=655248
==========

[Torne, 2016-12-01 15:27:53]

Description was changed from

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Also, move the function attributes into a macro so that the generated
header file is less repetitive (this also makes the generator less
repetitive as a bonus).

BUG=655248
==========

to

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248
==========

[Torne, 2016-12-01 15:29:13]

Can one of you take another look? I moved the function attributes and declspec
entirely into a macro in jni_generator_helpers.h which makes things look rather
nicer, and have renamed the golden header file so that clang-format ignores it
(because I don't especially want to run clang-format on the generated headers at
build time, and I don't want to have to make the generator match clang-format
behaviour). :)

[Torne, 2016-12-01 15:29:23]

The CQ bit was checked by torne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 15:29:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2016-12-01 16:06:42]

still lgtm

[Torne, 2016-12-01 16:40:17]

The CQ bit was unchecked by torne@chromium.org

[Torne, 2016-12-01 16:40:23]

The CQ bit was checked by torne@chromium.org

[Torne, 2016-12-01 16:40:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2531273002/#ps60001
(title: "Rename golden test file to satisfy presubmit")

[commit-bot: I haz the power, 2016-12-01 16:40:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 17:11:58]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480610423377350,
"parent_rev": "8c83d1d289d131449d888937e57c8c144029c6dc", "commit_rev":
"3e6a363a844fc2db5d17e282562be2b8b93e4f27"}

[commit-bot: I haz the power, 2016-12-01 17:12:24]

Description was changed from

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248
==========

to

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248
==========

[commit-bot: I haz the power, 2016-12-01 17:12:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-01 17:15:54]

Description was changed from

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248
==========

to

==========
android: Realign stack pointer on JNI entry.

Dalvik JIT generated code doesn't always align the stack to a 16 byte
boundary when calling into native, causing crashes in code that expects
16 byte alignment. Force the compiler to realign the stack when entering
native from Java, so that other code can assume 16 byte alignment as
expected by the ABI.

Move the function attributes into a macro so that the generated header
file is less repetitive (this also makes the generator less repetitive
as a bonus).

Also, to stop presubmit complaining about golden_sample_for_tests_jni.h
not being correctly clang-formatted, rename it to .golden like the other
test files.

BUG=655248

Committed: https://crrev.com/7be1137994eecca6c54831e4c3d3d4f934ea8602
Cr-Commit-Position: refs/heads/master@{#435632}
==========

[commit-bot: I haz the power, 2016-12-01 17:15:55]

Patchset 4 (id:??) landed as
https://crrev.com/7be1137994eecca6c54831e4c3d3d4f934ea8602
Cr-Commit-Position: refs/heads/master@{#435632}