Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2565703002: Check EXT_color_buffer_float extension is available (Closed)

Created:
4 years ago by qiankun
Modified:
4 years ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check EXT_color_buffer_float extension is available If the extension isn't available, we cannot read from fbo attaching float texture attachment. This CL adds error message when the extension is not available. BUG=369849, 624436 Committed: https://crrev.com/8d87790e2232d24b7e6f889ad9aa895851fa5c85 Cr-Commit-Position: refs/heads/master@{#437744}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M content/test/data/media/getusermedia-depth-capture.html View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
qiankun
PTAL.
4 years ago (2016-12-09 09:27:28 UTC) #2
aleksandar.stojiljkovic
On 2016/12/09 09:27:28, qiankun wrote: > PTAL. Thanks. LGTM with a nit: Consider adding the ...
4 years ago (2016-12-09 09:52:04 UTC) #3
qiankun
On 2016/12/09 09:52:04, aleksandar.stojiljkovic wrote: > On 2016/12/09 09:27:28, qiankun wrote: > > PTAL. > ...
4 years ago (2016-12-09 10:00:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565703002/1
4 years ago (2016-12-10 00:48:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 03:54:23 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-12 15:06:09 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d87790e2232d24b7e6f889ad9aa895851fa5c85
Cr-Commit-Position: refs/heads/master@{#437744}

Powered by Google App Engine
This is Rietveld 408576698