Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 2565673003: Fix window.history.go() with no parameter. (Closed)

Created:
4 years ago by kkhorimoto
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix window.history.go() with no parameter. BUG=673022 Committed: https://crrev.com/b7a4d89f56a89ebf6c65cbe5f568143f86cde70e Cr-Commit-Position: refs/heads/master@{#437982}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix bug in javascript #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ios/web/web_state/js/resources/core.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
kkhorimoto
4 years ago (2016-12-09 22:36:55 UTC) #2
Eugene But (OOO till 7-30)
https://codereview.chromium.org/2565673003/diff/1/ios/web/web_state/ui/crw_web_controller.mm File ios/web/web_state/ui/crw_web_controller.mm (right): https://codereview.chromium.org/2565673003/diff/1/ios/web/web_state/ui/crw_web_controller.mm#newcode3089 ios/web/web_state/ui/crw_web_controller.mm:3089: // window.history.go() with no input parameter should behave as ...
4 years ago (2016-12-09 22:58:20 UTC) #3
kkhorimoto
https://codereview.chromium.org/2565673003/diff/1/ios/web/web_state/ui/crw_web_controller.mm File ios/web/web_state/ui/crw_web_controller.mm (right): https://codereview.chromium.org/2565673003/diff/1/ios/web/web_state/ui/crw_web_controller.mm#newcode3089 ios/web/web_state/ui/crw_web_controller.mm:3089: // window.history.go() with no input parameter should behave as ...
4 years ago (2016-12-13 00:30:56 UTC) #4
Eugene But (OOO till 7-30)
lgtm!
4 years ago (2016-12-13 01:33:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565673003/20001
4 years ago (2016-12-13 01:42:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 01:55:01 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-13 01:57:10 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b7a4d89f56a89ebf6c65cbe5f568143f86cde70e
Cr-Commit-Position: refs/heads/master@{#437982}

Powered by Google App Engine
This is Rietveld 408576698