Reorganize InheritedRefenenceContributor to serve angular completion

Reorganize InheritedRefenenceContributor to serve angular completion

Take the parts that I would have simply copied and pasted them into my
own code, and create new public & private methods to serve the new
organization.

Add an option to get the current class's accessors/methods along with
the inherited ones, because that's what I want.

Make opType a public member of DartCompletionRequest

Its used so heavily by so many of the autocomplete targets, it really
doesn't need to be hidden on the Impl.

Besides, I want to use InheritedReferenceContributor, which upcasts the
DartCompletionRequest into the Impl in order to grab this field -- but
for a large number of reasons I can't really use
DartCompletionRequestImpl. Therefore I need my own class to implement
DartCompletionRequest and therefore my code will only work with
InheritedReferenceContributor if it doesn't have to look outside the
interface for this information.

Change to enable the angular analysis project to do autocomplete

We don't have CompilationUnits, but we do have dart ASTs, and we want to
find the completion target with the same algorithm. The CompletionTarget
class's functionality doesn't depend on its member compilationUnit not
being null, so that isn't a problem for us. However, in `forOffset()`,
we cannot pass in a null unit, even though its only used to set the
`compilationUnit` member and otherwise only used as an `AstNode` which
we have.

So rather than using `compilationUnit` as the entry point of the
algorithm, add a new `AstNode` parameter to represent the entry point,
and when its null simply use the value of `compilationUnit`.

BUG=
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/d8c9645c260d163679b4193661566df87cfa9515

[mfairhurst, 2016-12-09 17:00:56]

Description was changed from

==========
Reorganize InheritedRefenenceContributor to serve angular completion

Take the parts that I would have simply copied and pasted them into my
own code, and create new public & private methods to serve the new
organization.

Add an option to get the current class's accessors/methods along with
the inherited ones, because that's what I want.

Make opType a public member of DartCompletionRequest

Its used so heavily by so many of the autocomplete targets, it really
doesn't need to be hidden on the Impl.

Besides, I want to use InheritedReferenceContributor, which upcasts the
DartCompletionRequest into the Impl in order to grab this field -- but
for a large number of reasons I can't really use
DartCompletionRequestImpl. Therefore I need my own class to implement
DartCompletionRequest and therefore my code will only work with
InheritedReferenceContributor if it doesn't have to look outside the
interface for this information.

Change to enable the angular analysis project to do autocomplete

We don't have CompilationUnits, but we do have dart ASTs, and we want to
find the completion target with the same algorithm. The CompletionTarget
class's functionality doesn't depend on its member compilationUnit not
being null, so that isn't a problem for us. However, in `forOffset()`,
we cannot pass in a null unit, even though its only used to set the
`compilationUnit` member and otherwise only used as an `AstNode` which
we have.

So rather than using `compilationUnit` as the entry point of the
algorithm, add a new `AstNode` parameter to represent the entry point,
and when its null simply use the value of `compilationUnit`.

BUG=
==========

to

==========
Reorganize InheritedRefenenceContributor to serve angular completion

Take the parts that I would have simply copied and pasted them into my
own code, and create new public & private methods to serve the new
organization.

Add an option to get the current class's accessors/methods along with
the inherited ones, because that's what I want.

Make opType a public member of DartCompletionRequest

Its used so heavily by so many of the autocomplete targets, it really
doesn't need to be hidden on the Impl.

Besides, I want to use InheritedReferenceContributor, which upcasts the
DartCompletionRequest into the Impl in order to grab this field -- but
for a large number of reasons I can't really use
DartCompletionRequestImpl. Therefore I need my own class to implement
DartCompletionRequest and therefore my code will only work with
InheritedReferenceContributor if it doesn't have to look outside the
interface for this information.

Change to enable the angular analysis project to do autocomplete

We don't have CompilationUnits, but we do have dart ASTs, and we want to
find the completion target with the same algorithm. The CompletionTarget
class's functionality doesn't depend on its member compilationUnit not
being null, so that isn't a problem for us. However, in `forOffset()`,
we cannot pass in a null unit, even though its only used to set the
`compilationUnit` member and otherwise only used as an `AstNode` which
we have.

So rather than using `compilationUnit` as the entry point of the
algorithm, add a new `AstNode` parameter to represent the entry point,
and when its null simply use the value of `compilationUnit`.

BUG=
==========

[mfairhurst, 2016-12-09 17:00:56]

mfairhurst@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[mfairhurst, 2016-12-09 17:01:52]

Work I did to enable the analyzer to do dart autocomplete. Let me know if it
needs a different approach.

[Brian Wilkerson, 2016-12-09 17:15:19]

lgtm

https://codereview.chromium.org/2565633002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart
(right):

https://codereview.chromium.org/2565633002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/dart/completion_dart.dart:103:
* The OpType which describes which types of suggestions would fit the request
nit: missing period

https://codereview.chromium.org/2565633002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart
(right):

https://codereview.chromium.org/2565633002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart:163:
}
Or just "entryPoint ??= compilationUnit;" (in place of the 'if' statement).

https://codereview.chromium.org/2565633002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart
(right):

https://codereview.chromium.org/2565633002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart:74:
List<CompletionSuggestion> _computeSuggestionsForClass2(
As far as I can see, this is only invoked in one place. Is there a reason for it
to not be inlined? (I am trying to understand what the difference is between it
and 'computeSuggestionsForClass' and why it's a separate method.)

[mfairhurst, 2016-12-09 17:31:41]

https://codereview.chromium.org/2565633002/diff/1/pkg/analysis_server/lib/src...
File
pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart
(right):

https://codereview.chromium.org/2565633002/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart:74:
List<CompletionSuggestion> _computeSuggestionsForClass2(
On 2016/12/09 17:15:19, Brian Wilkerson wrote:
> As far as I can see, this is only invoked in one place. Is there a reason for
it
> to not be inlined? (I am trying to understand what the difference is between
it
> and 'computeSuggestionsForClass' and why it's a separate method.)

computeSuggestions should call this, but its in there wrongly as
_computeSuggestionsForParentsOfClass. Now trying to get tests working in the
analysis server with depot tools...

[mfairhurst, 2016-12-09 18:50:17]

On 2016/12/09 17:31:41, mfairhurst wrote:
>
https://codereview.chromium.org/2565633002/diff/1/pkg/analysis_server/lib/src...
> File
>
pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart
> (right):
> 
>
https://codereview.chromium.org/2565633002/diff/1/pkg/analysis_server/lib/src...
>
pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart:74:
> List<CompletionSuggestion> _computeSuggestionsForClass2(
> On 2016/12/09 17:15:19, Brian Wilkerson wrote:
> > As far as I can see, this is only invoked in one place. Is there a reason
for
> it
> > to not be inlined? (I am trying to understand what the difference is between
> it
> > and 'computeSuggestionsForClass' and why it's a separate method.)
> 
> computeSuggestions should call this, but its in there wrongly as
> _computeSuggestionsForParentsOfClass. Now trying to get tests working in the
> analysis server with depot tools...

OK tests running (again) and passing (again).

[Brian Wilkerson, 2016-12-12 22:26:58]

lgtm

[mfairhurst, 2016-12-12 22:29:57]

Description was changed from

==========
Reorganize InheritedRefenenceContributor to serve angular completion

Take the parts that I would have simply copied and pasted them into my
own code, and create new public & private methods to serve the new
organization.

Add an option to get the current class's accessors/methods along with
the inherited ones, because that's what I want.

Make opType a public member of DartCompletionRequest

Its used so heavily by so many of the autocomplete targets, it really
doesn't need to be hidden on the Impl.

Besides, I want to use InheritedReferenceContributor, which upcasts the
DartCompletionRequest into the Impl in order to grab this field -- but
for a large number of reasons I can't really use
DartCompletionRequestImpl. Therefore I need my own class to implement
DartCompletionRequest and therefore my code will only work with
InheritedReferenceContributor if it doesn't have to look outside the
interface for this information.

Change to enable the angular analysis project to do autocomplete

We don't have CompilationUnits, but we do have dart ASTs, and we want to
find the completion target with the same algorithm. The CompletionTarget
class's functionality doesn't depend on its member compilationUnit not
being null, so that isn't a problem for us. However, in `forOffset()`,
we cannot pass in a null unit, even though its only used to set the
`compilationUnit` member and otherwise only used as an `AstNode` which
we have.

So rather than using `compilationUnit` as the entry point of the
algorithm, add a new `AstNode` parameter to represent the entry point,
and when its null simply use the value of `compilationUnit`.

BUG=
==========

to

==========
Reorganize InheritedRefenenceContributor to serve angular completion

Take the parts that I would have simply copied and pasted them into my
own code, and create new public & private methods to serve the new
organization.

Add an option to get the current class's accessors/methods along with
the inherited ones, because that's what I want.

Make opType a public member of DartCompletionRequest

Its used so heavily by so many of the autocomplete targets, it really
doesn't need to be hidden on the Impl.

Besides, I want to use InheritedReferenceContributor, which upcasts the
DartCompletionRequest into the Impl in order to grab this field -- but
for a large number of reasons I can't really use
DartCompletionRequestImpl. Therefore I need my own class to implement
DartCompletionRequest and therefore my code will only work with
InheritedReferenceContributor if it doesn't have to look outside the
interface for this information.

Change to enable the angular analysis project to do autocomplete

We don't have CompilationUnits, but we do have dart ASTs, and we want to
find the completion target with the same algorithm. The CompletionTarget
class's functionality doesn't depend on its member compilationUnit not
being null, so that isn't a problem for us. However, in `forOffset()`,
we cannot pass in a null unit, even though its only used to set the
`compilationUnit` member and otherwise only used as an `AstNode` which
we have.

So rather than using `compilationUnit` as the entry point of the
algorithm, add a new `AstNode` parameter to represent the entry point,
and when its null simply use the value of `compilationUnit`.

BUG=
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/d8c9645c260d163679b4193661566df87cfa9515
==========

[mfairhurst, 2016-12-12 22:29:58]

Committed patchset #3 (id:40001) manually as
d8c9645c260d163679b4193661566df87cfa9515 (presubmit successful).