pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart - Issue 2565633002: Reorganize InheritedRefenenceContributor to serve angular completion

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

Issue 2565633002: Reorganize InheritedRefenenceContributor to serve angular completion (Closed)

Patch Set: Fix bad merge. Tests passing. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/provisional/completion/dart/completion_target.dart ('k') | pkg/analysis_server/lib/src/services/completion/dart/inherited_reference_contributor.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

diff --git a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

index 1290f70ae764e4f5f20277db247b9558f8d99439..6a9ac4314ec64e2fb281d88b832bb4d8d7b5f405 100644

--- a/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

+++ b/pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart

@@ -192,12 +192,7 @@ class DartCompletionRequestImpl implements DartCompletionRequest {

@override

bool get includeIdentifiers {

- opType; // <<< ensure _opType is initialized

- return !_opType.isPrefixed &&

- (_opType.includeReturnValueSuggestions ||

- _opType.includeTypeNameSuggestions ||

- _opType.includeVoidReturnSuggestions ||

- _opType.includeConstructorSuggestions);

+ return opType.includeIdentifiers;

}

@override