Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2565403002: Perform "zoom compensation" for 'transform' on <svg:text> (Closed)

Created:
4 years ago by fs
Modified:
4 years ago
Reviewers:
pdr.
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Perform "zoom compensation" for 'transform' on <svg:text> SVGElement::calculateTransform would not compensate for effective zoom on 'transform' for SVG <text> elements. Refactor the code a bit so that the different parameter configurations are selected first, and then use the same code for both <text> and non- <text>. This makes sure that effective zoom is factored into the computed transform for <text> as well. BUG=665387, 369942 Committed: https://crrev.com/12ed8948ab2de41a58831f3093f8c5ca6f997493 Cr-Commit-Position: refs/heads/master@{#437927}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -30 lines) Patch
A third_party/WebKit/LayoutTests/svg/transforms/text-with-transform-and-zoom.html View 1 chunk +6 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/transforms/text-with-transform-and-zoom-expected.html View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 1 chunk +28 lines, -30 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
fs
4 years ago (2016-12-12 14:11:57 UTC) #5
pdr.
On 2016/12/12 at 14:11:57, fs wrote: > LGTM
4 years ago (2016-12-12 18:44:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565403002/1
4 years ago (2016-12-12 18:46:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 22:13:43 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-12 22:16:05 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12ed8948ab2de41a58831f3093f8c5ca6f997493
Cr-Commit-Position: refs/heads/master@{#437927}

Powered by Google App Engine
This is Rietveld 408576698