Revert of Do not generate a microdump if there are no webview pointers on the stack.

Revert of Do not generate a microdump if there are no webview pointers on the stack. (patchset #6 id:100001 of https://codereview.chromium.org/2552753002/ )

Reason for revert:
Revert in preparation for modifying breakpad to infer the interest
region from mappings rather than being explicitly informed.

Linux ld.so refuses to relocate absolutely addressed symbols at offset 0,
causing the use of __executable_start to fail at load time on that platform.
We will need to find a better way to determine the extent of the text
section.

Original issue's description:
> Do not generate a microdump if there are no webview pointers on the stack.
>
> To determine the webview text section address range, we use the linker
> defines symbols __executable_start and __etext. These are passed to
> breakpad in the microdump extra info struct, causing it to not generate
> a microdump if the stack of the crashing thread does not contain a
> pointer into this region.
>
> BUG=664460
>
> Committed: https://crrev.com/19f0a50c6eab29917f459557b10cafc70428a4a2
> Committed: https://crrev.com/aca68a011a9fd116972e329871f67c73ca8ca389
> Cr-Original-Commit-Position: refs/heads/master@{#437003}
> Cr-Commit-Position: refs/heads/master@{#437234}

TBR=primiano@chromium.org,torne@chromium.org,rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664460
Committed: https://crrev.com/66bc013d45532f4cbc35198b87f037f0344d15da
Cr-Commit-Position: refs/heads/master@{#438150}

[Tobias Sargeant, 2016-12-13 12:24:16]

The CQ bit was checked by tobiasjs@chromium.org

[Tobias Sargeant, 2016-12-13 12:24:17]

Created Revert of Do not generate a microdump if there are no webview pointers
on the stack.

[commit-bot: I haz the power, 2016-12-13 12:24:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Primiano Tucci (use gerrit), 2016-12-13 12:52:20]

LGTM .
i think you could mention the issue you found on the Linux loader (ld.so)
complaining about relocatable addresses at text 0, which gives context about why
you are backtracking here.

[Tobias Sargeant, 2016-12-13 13:05:20]

The CQ bit was unchecked by tobiasjs@chromium.org

[Tobias Sargeant, 2016-12-13 13:08:07]

Description was changed from

==========
Revert of Do not generate a microdump if there are no webview pointers on the
stack. (patchset #6 id:100001 of https://codereview.chromium.org/2552753002/ )

Reason for revert:
Revert in preparation for modifying breakpad to infer the interest region from
mappings rather than being explicitly informed.

Original issue's description:
> Do not generate a microdump if there are no webview pointers on the stack.
> 
> To determine the webview text section address range, we use the linker
> defines symbols __executable_start and __etext. These are passed to
> breakpad in the microdump extra info struct, causing it to not generate
> a microdump if the stack of the crashing thread does not contain a
> pointer into this region.
> 
> BUG=664460
> 
> Committed: https://crrev.com/19f0a50c6eab29917f459557b10cafc70428a4a2
> Committed: https://crrev.com/aca68a011a9fd116972e329871f67c73ca8ca389
> Cr-Original-Commit-Position: refs/heads/master@{#437003}
> Cr-Commit-Position: refs/heads/master@{#437234}

TBR=primiano@chromium.org,torne@chromium.org,rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664460
==========

to

==========
Revert of Do not generate a microdump if there are no webview pointers on the
stack. (patchset #6 id:100001 of https://codereview.chromium.org/2552753002/ )

Reason for revert:
Revert in preparation for modifying breakpad to infer the interest
region from mappings rather than being explicitly informed.

Linux ld.so refuses to relocate absolutely addressed symbols at offset 0,
causing the use of __executable_start to fail at load time on that platform.
We will need to find a better way to determine the extent of the text
section.

Original issue's description:
> Do not generate a microdump if there are no webview pointers on the stack.
> 
> To determine the webview text section address range, we use the linker
> defines symbols __executable_start and __etext. These are passed to
> breakpad in the microdump extra info struct, causing it to not generate
> a microdump if the stack of the crashing thread does not contain a
> pointer into this region.
> 
> BUG=664460
> 
> Committed: https://crrev.com/19f0a50c6eab29917f459557b10cafc70428a4a2
> Committed: https://crrev.com/aca68a011a9fd116972e329871f67c73ca8ca389
> Cr-Original-Commit-Position: refs/heads/master@{#437003}
> Cr-Commit-Position: refs/heads/master@{#437234}

TBR=primiano@chromium.org,torne@chromium.org,rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664460
==========

[Tobias Sargeant, 2016-12-13 13:08:17]

The CQ bit was checked by tobiasjs@chromium.org

[commit-bot: I haz the power, 2016-12-13 13:08:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 13:12:59]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481634497221930, "parent_rev":
"52f2efc13b6f2abef1e202c4baae940cb1b9223f", "commit_rev":
"71a15d76b21a580f5ec0f3340d4d01c1deed18ab"}

[commit-bot: I haz the power, 2016-12-13 13:13:26]

Description was changed from

==========
Revert of Do not generate a microdump if there are no webview pointers on the
stack. (patchset #6 id:100001 of https://codereview.chromium.org/2552753002/ )

Reason for revert:
Revert in preparation for modifying breakpad to infer the interest
region from mappings rather than being explicitly informed.

Linux ld.so refuses to relocate absolutely addressed symbols at offset 0,
causing the use of __executable_start to fail at load time on that platform.
We will need to find a better way to determine the extent of the text
section.

Original issue's description:
> Do not generate a microdump if there are no webview pointers on the stack.
> 
> To determine the webview text section address range, we use the linker
> defines symbols __executable_start and __etext. These are passed to
> breakpad in the microdump extra info struct, causing it to not generate
> a microdump if the stack of the crashing thread does not contain a
> pointer into this region.
> 
> BUG=664460
> 
> Committed: https://crrev.com/19f0a50c6eab29917f459557b10cafc70428a4a2
> Committed: https://crrev.com/aca68a011a9fd116972e329871f67c73ca8ca389
> Cr-Original-Commit-Position: refs/heads/master@{#437003}
> Cr-Commit-Position: refs/heads/master@{#437234}

TBR=primiano@chromium.org,torne@chromium.org,rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664460
==========

to

==========
Revert of Do not generate a microdump if there are no webview pointers on the
stack. (patchset #6 id:100001 of https://codereview.chromium.org/2552753002/ )

Reason for revert:
Revert in preparation for modifying breakpad to infer the interest
region from mappings rather than being explicitly informed.

Linux ld.so refuses to relocate absolutely addressed symbols at offset 0,
causing the use of __executable_start to fail at load time on that platform.
We will need to find a better way to determine the extent of the text
section.

Original issue's description:
> Do not generate a microdump if there are no webview pointers on the stack.
> 
> To determine the webview text section address range, we use the linker
> defines symbols __executable_start and __etext. These are passed to
> breakpad in the microdump extra info struct, causing it to not generate
> a microdump if the stack of the crashing thread does not contain a
> pointer into this region.
> 
> BUG=664460
> 
> Committed: https://crrev.com/19f0a50c6eab29917f459557b10cafc70428a4a2
> Committed: https://crrev.com/aca68a011a9fd116972e329871f67c73ca8ca389
> Cr-Original-Commit-Position: refs/heads/master@{#437003}
> Cr-Commit-Position: refs/heads/master@{#437234}

TBR=primiano@chromium.org,torne@chromium.org,rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664460

Review-Url: https://codereview.chromium.org/2565353004
==========

[commit-bot: I haz the power, 2016-12-13 13:13:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 13:16:30]

Description was changed from

==========
Revert of Do not generate a microdump if there are no webview pointers on the
stack. (patchset #6 id:100001 of https://codereview.chromium.org/2552753002/ )

Reason for revert:
Revert in preparation for modifying breakpad to infer the interest
region from mappings rather than being explicitly informed.

Linux ld.so refuses to relocate absolutely addressed symbols at offset 0,
causing the use of __executable_start to fail at load time on that platform.
We will need to find a better way to determine the extent of the text
section.

Original issue's description:
> Do not generate a microdump if there are no webview pointers on the stack.
> 
> To determine the webview text section address range, we use the linker
> defines symbols __executable_start and __etext. These are passed to
> breakpad in the microdump extra info struct, causing it to not generate
> a microdump if the stack of the crashing thread does not contain a
> pointer into this region.
> 
> BUG=664460
> 
> Committed: https://crrev.com/19f0a50c6eab29917f459557b10cafc70428a4a2
> Committed: https://crrev.com/aca68a011a9fd116972e329871f67c73ca8ca389
> Cr-Original-Commit-Position: refs/heads/master@{#437003}
> Cr-Commit-Position: refs/heads/master@{#437234}

TBR=primiano@chromium.org,torne@chromium.org,rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664460

Review-Url: https://codereview.chromium.org/2565353004
==========

to

==========
Revert of Do not generate a microdump if there are no webview pointers on the
stack. (patchset #6 id:100001 of https://codereview.chromium.org/2552753002/ )

Reason for revert:
Revert in preparation for modifying breakpad to infer the interest
region from mappings rather than being explicitly informed.

Linux ld.so refuses to relocate absolutely addressed symbols at offset 0,
causing the use of __executable_start to fail at load time on that platform.
We will need to find a better way to determine the extent of the text
section.

Original issue's description:
> Do not generate a microdump if there are no webview pointers on the stack.
>
> To determine the webview text section address range, we use the linker
> defines symbols __executable_start and __etext. These are passed to
> breakpad in the microdump extra info struct, causing it to not generate
> a microdump if the stack of the crashing thread does not contain a
> pointer into this region.
>
> BUG=664460
>
> Committed: https://crrev.com/19f0a50c6eab29917f459557b10cafc70428a4a2
> Committed: https://crrev.com/aca68a011a9fd116972e329871f67c73ca8ca389
> Cr-Original-Commit-Position: refs/heads/master@{#437003}
> Cr-Commit-Position: refs/heads/master@{#437234}

TBR=primiano@chromium.org,torne@chromium.org,rsesek@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=664460

Committed: https://crrev.com/66bc013d45532f4cbc35198b87f037f0344d15da
Cr-Commit-Position: refs/heads/master@{#438150}
==========

[commit-bot: I haz the power, 2016-12-13 13:16:30]

Patchset 1 (id:??) landed as
https://crrev.com/66bc013d45532f4cbc35198b87f037f0344d15da
Cr-Commit-Position: refs/heads/master@{#438150}