Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2565343003: DevTools: do not show dynamically-added stylesheets in navigator (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: do not show dynamically-added stylesheets in navigator Today, we accidentally add dynamically added inline stylesheets in the navigator view. They are displayed as "(index)" styles, and bring in confusion. This patch makes sure we don't create a UISourceCode for stylesheet unless it have a url. BUG=none R=dgozman Committed: https://crrev.com/d67e6b30461cc4c663a015d90d7cd7e9f1ba220b Cr-Commit-Position: refs/heads/master@{#438104}

Patch Set 1 #

Total comments: 2

Patch Set 2 : move test #

Messages

Total messages: 12 (5 generated)
lushnikov
please, take a look
4 years ago (2016-12-13 00:19:44 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2565343003/diff/1/third_party/WebKit/LayoutTests/inspector/elements/styles/styles-do-not-add-inline-stylesheets-in-navigator-expected.txt File third_party/WebKit/LayoutTests/inspector/elements/styles/styles-do-not-add-inline-stylesheets-in-navigator-expected.txt (right): https://codereview.chromium.org/2565343003/diff/1/third_party/WebKit/LayoutTests/inspector/elements/styles/styles-do-not-add-inline-stylesheets-in-navigator-expected.txt#newcode5 third_party/WebKit/LayoutTests/inspector/elements/styles/styles-do-not-add-inline-stylesheets-in-navigator-expected.txt:5: usr/local/google/blink/src/third_party/WebKit/LayoutTests http test ftw!
4 years ago (2016-12-13 03:13:24 UTC) #2
lushnikov
https://codereview.chromium.org/2565343003/diff/1/third_party/WebKit/LayoutTests/inspector/elements/styles/styles-do-not-add-inline-stylesheets-in-navigator-expected.txt File third_party/WebKit/LayoutTests/inspector/elements/styles/styles-do-not-add-inline-stylesheets-in-navigator-expected.txt (right): https://codereview.chromium.org/2565343003/diff/1/third_party/WebKit/LayoutTests/inspector/elements/styles/styles-do-not-add-inline-stylesheets-in-navigator-expected.txt#newcode5 third_party/WebKit/LayoutTests/inspector/elements/styles/styles-do-not-add-inline-stylesheets-in-navigator-expected.txt:5: usr/local/google/blink/src/third_party/WebKit/LayoutTests On 2016/12/13 03:13:23, dgozman wrote: > http test ...
4 years ago (2016-12-13 07:24:34 UTC) #3
lushnikov
4 years ago (2016-12-13 07:24:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565343003/20001
4 years ago (2016-12-13 07:25:05 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 09:01:01 UTC) #10
commit-bot: I haz the power
4 years ago (2016-12-13 09:02:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d67e6b30461cc4c663a015d90d7cd7e9f1ba220b
Cr-Commit-Position: refs/heads/master@{#438104}

Powered by Google App Engine
This is Rietveld 408576698