Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Issue 2565343002: [wasm][asm.js] Require a number for fround literals. (Closed)

Created:
4 years ago by bradnelson
Modified:
4 years ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm][asm.js] Require a number for fround literals. BUG=673240 R=titzer@chromium.org Committed: https://crrev.com/626d620d4d130485b5a4ea14bfb9097038ab3575 Cr-Commit-Position: refs/heads/master@{#41643}

Patch Set 1 #

Patch Set 2 : git cl try #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/asmjs/asm-typer.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/mjsunit/asm/asm-validation.js View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
titzer
On 2016/12/12 10:20:21, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years ago (2016-12-12 13:47:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565343002/20001
4 years ago (2016-12-12 13:49:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-12 13:51:13 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 13:51:34 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/626d620d4d130485b5a4ea14bfb9097038ab3575
Cr-Commit-Position: refs/heads/master@{#41643}

Powered by Google App Engine
This is Rietveld 408576698