Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1371)

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h

Issue 2565323003: Move gif image decoder to SkCodec (Closed)
Patch Set: Adding SegmentStreamTest.cpp, more null checks, and updating m_hasReadAllContents more. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h
diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h
index e84b1b488dc443a73ab341e658cac98e49b771a7..98200e73f121ddf759d2c10c8702cc60787d53f3 100644
--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h
+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.h
@@ -26,13 +26,12 @@
#ifndef GIFImageDecoder_h
#define GIFImageDecoder_h
+#include <memory>
#include "platform/image-decoders/ImageDecoder.h"
+#include "platform/image-decoders/SegmentStream.h"
+#include "third_party/skia/include/codec/SkCodec.h"
#include "wtf/Noncopyable.h"
-#include <memory>
-
-class GIFImageReader;
-
-typedef Vector<unsigned char> GIFRow;
+#include "wtf/RefPtr.h"
namespace blink {
@@ -44,56 +43,35 @@ class PLATFORM_EXPORT GIFImageDecoder final : public ImageDecoder {
GIFImageDecoder(AlphaOption, const ColorBehavior&, size_t maxDecodedBytes);
~GIFImageDecoder() override;
- enum GIFParseQuery { GIFSizeQuery, GIFFrameCountQuery };
-
// ImageDecoder:
String filenameExtension() const override { return "gif"; }
void onSetData(SegmentReader* data) override;
int repetitionCount() const override;
bool frameIsCompleteAtIndex(size_t) const override;
float frameDurationAtIndex(size_t) const override;
- // CAUTION: setFailed() deletes |m_reader|. Be careful to avoid
- // accessing deleted memory, especially when calling this from inside
- // GIFImageReader!
- bool setFailed() override;
-
- // Callbacks from the GIF reader.
- bool haveDecodedRow(size_t frameIndex,
- GIFRow::const_iterator rowBegin,
- size_t width,
- size_t rowNumber,
- unsigned repeatCount,
- bool writeTransparentPixels);
- bool frameComplete(size_t frameIndex);
-
- // For testing.
- bool parseCompleted() const;
private:
// ImageDecoder:
- void clearFrameBuffer(size_t frameIndex) override;
- virtual void decodeSize() { parse(GIFSizeQuery); }
+ void decodeSize() override {}
size_t decodeFrameCount() override;
- void initializeNewFrame(size_t) override;
+ void initializeNewFrame(size_t index) override;
void decode(size_t) override;
-
- // Parses as much as is needed to answer the query, ignoring bitmap
- // data. If parsing fails, sets the "decode failure" flag.
- void parse(GIFParseQuery);
-
- // Reset the alpha tracker for this frame. Before calling this method, the
- // caller must verify that the frame exists.
- void onInitFrameBuffer(size_t) override;
-
+ bool frameStatusSufficientForSuccessors(size_t index) {
+ DCHECK(index < m_frameBufferCache.size());
+ return m_frameBufferCache[index].getStatus() == ImageFrame::FrameComplete;
+ }
// When the disposal method of the frame is DisposeOverWritePrevious, the
// next frame will use the previous frame's buffer as its starting state, so
// we can't take over the data in that case. Before calling this method, the
// caller must verify that the frame exists.
bool canReusePreviousFrameBuffer(size_t) const override;
- bool m_currentBufferSawAlpha;
- mutable int m_repetitionCount;
- std::unique_ptr<GIFImageReader> m_reader;
+ std::unique_ptr<SkCodec> m_codec;
+ // m_segmentStream is a raw pointer because it passes ownership to
+ // m_codec when m_codec is created. However, we still need the
+ // pointer so we can append more data as it arrives.
+ SegmentStream* m_segmentStream;
+ std::vector<SkCodec::FrameInfo> m_frameInfos;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698