Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Side by Side Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoderTest.cpp

Issue 2565323003: Move gif image decoder to SkCodec (Closed)
Patch Set: More code review comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
52 ImageDecoder::kNoDecodedImageByteLimit)); 52 ImageDecoder::kNoDecodedImageByteLimit));
53 } 53 }
54 54
55 void TestRepetitionCount(const char* dir, 55 void TestRepetitionCount(const char* dir,
56 const char* file, 56 const char* file,
57 int expected_repetition_count) { 57 int expected_repetition_count) {
58 std::unique_ptr<ImageDecoder> decoder = CreateDecoder(); 58 std::unique_ptr<ImageDecoder> decoder = CreateDecoder();
59 RefPtr<SharedBuffer> data = ReadFile(dir, file); 59 RefPtr<SharedBuffer> data = ReadFile(dir, file);
60 ASSERT_TRUE(data.Get()); 60 ASSERT_TRUE(data.Get());
61 decoder->SetData(data.Get(), true); 61 decoder->SetData(data.Get(), true);
62 EXPECT_EQ(kCAnimationLoopOnce,
63 decoder->RepetitionCount()); // Default value before decode.
64 62
65 for (size_t i = 0; i < decoder->FrameCount(); ++i) { 63 EXPECT_EQ(expected_repetition_count, decoder->RepetitionCount());
66 ImageFrame* frame = decoder->FrameBufferAtIndex(i);
67 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus());
68 }
69
70 EXPECT_EQ(expected_repetition_count,
71 decoder->RepetitionCount()); // Expected value after decode.
72 } 64 }
73 65
74 } // anonymous namespace 66 } // anonymous namespace
75 67
76 TEST(GIFImageDecoderTest, decodeTwoFrames) { 68 TEST(GIFImageDecoderTest, decodeTwoFrames) {
77 std::unique_ptr<ImageDecoder> decoder = CreateDecoder(); 69 std::unique_ptr<ImageDecoder> decoder = CreateDecoder();
78 70
79 RefPtr<SharedBuffer> data = ReadFile(kLayoutTestResourcesDir, "animated.gif"); 71 RefPtr<SharedBuffer> data = ReadFile(kLayoutTestResourcesDir, "animated.gif");
80 ASSERT_TRUE(data.Get()); 72 ASSERT_TRUE(data.Get());
81 decoder->SetData(data.Get(), true); 73 decoder->SetData(data.Get(), true);
82 EXPECT_EQ(kCAnimationLoopOnce, decoder->RepetitionCount());
83 74
84 ImageFrame* frame = decoder->FrameBufferAtIndex(0); 75 ImageFrame* frame = decoder->FrameBufferAtIndex(0);
85 uint32_t generation_id0 = frame->Bitmap().getGenerationID(); 76 uint32_t generation_id0 = frame->Bitmap().getGenerationID();
86 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus()); 77 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus());
87 EXPECT_EQ(16, frame->Bitmap().width()); 78 EXPECT_EQ(16, frame->Bitmap().width());
88 EXPECT_EQ(16, frame->Bitmap().height()); 79 EXPECT_EQ(16, frame->Bitmap().height());
89 80
90 frame = decoder->FrameBufferAtIndex(1); 81 frame = decoder->FrameBufferAtIndex(1);
91 uint32_t generation_id1 = frame->Bitmap().getGenerationID(); 82 uint32_t generation_id1 = frame->Bitmap().getGenerationID();
92 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus()); 83 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus());
93 EXPECT_EQ(16, frame->Bitmap().width()); 84 EXPECT_EQ(16, frame->Bitmap().width());
94 EXPECT_EQ(16, frame->Bitmap().height()); 85 EXPECT_EQ(16, frame->Bitmap().height());
95 EXPECT_TRUE(generation_id0 != generation_id1); 86 EXPECT_TRUE(generation_id0 != generation_id1);
96 87
97 EXPECT_EQ(2u, decoder->FrameCount()); 88 EXPECT_EQ(2u, decoder->FrameCount());
98 EXPECT_EQ(kCAnimationLoopInfinite, decoder->RepetitionCount()); 89 EXPECT_EQ(kCAnimationLoopInfinite, decoder->RepetitionCount());
99 } 90 }
100 91
101 TEST(GIFImageDecoderTest, parseAndDecode) { 92 TEST(GIFImageDecoderTest, parseAndDecode) {
102 std::unique_ptr<ImageDecoder> decoder = CreateDecoder(); 93 std::unique_ptr<ImageDecoder> decoder = CreateDecoder();
103 94
104 RefPtr<SharedBuffer> data = ReadFile(kLayoutTestResourcesDir, "animated.gif"); 95 RefPtr<SharedBuffer> data = ReadFile(kLayoutTestResourcesDir, "animated.gif");
105 ASSERT_TRUE(data.Get()); 96 ASSERT_TRUE(data.Get());
106 decoder->SetData(data.Get(), true); 97 decoder->SetData(data.Get(), true);
107 EXPECT_EQ(kCAnimationLoopOnce, decoder->RepetitionCount());
108
109 // This call will parse the entire file.
110 EXPECT_EQ(2u, decoder->FrameCount());
111 98
112 ImageFrame* frame = decoder->FrameBufferAtIndex(0); 99 ImageFrame* frame = decoder->FrameBufferAtIndex(0);
113 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus()); 100 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus());
114 EXPECT_EQ(16, frame->Bitmap().width()); 101 EXPECT_EQ(16, frame->Bitmap().width());
115 EXPECT_EQ(16, frame->Bitmap().height()); 102 EXPECT_EQ(16, frame->Bitmap().height());
116 103
117 frame = decoder->FrameBufferAtIndex(1); 104 frame = decoder->FrameBufferAtIndex(1);
118 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus()); 105 EXPECT_EQ(ImageFrame::kFrameComplete, frame->GetStatus());
119 EXPECT_EQ(16, frame->Bitmap().width()); 106 EXPECT_EQ(16, frame->Bitmap().width());
120 EXPECT_EQ(16, frame->Bitmap().height()); 107 EXPECT_EQ(16, frame->Bitmap().height());
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
301 ReadFile(kDecodersTestingDir, "bad-code.gif"); 288 ReadFile(kDecodersTestingDir, "bad-code.gif");
302 ASSERT_TRUE(test_data.Get()); 289 ASSERT_TRUE(test_data.Get());
303 290
304 std::unique_ptr<ImageDecoder> test_decoder = CreateDecoder(); 291 std::unique_ptr<ImageDecoder> test_decoder = CreateDecoder();
305 test_decoder->SetData(test_data.Get(), true); 292 test_decoder->SetData(test_data.Get(), true);
306 EXPECT_EQ(1u, test_decoder->FrameCount()); 293 EXPECT_EQ(1u, test_decoder->FrameCount());
307 ASSERT_TRUE(test_decoder->FrameBufferAtIndex(0)); 294 ASSERT_TRUE(test_decoder->FrameBufferAtIndex(0));
308 EXPECT_TRUE(test_decoder->Failed()); 295 EXPECT_TRUE(test_decoder->Failed());
309 } 296 }
310 297
311 TEST(GIFImageDecoderTest, invalidDisposalMethod) {
312 std::unique_ptr<ImageDecoder> decoder = CreateDecoder();
313
314 // The image has 2 frames, with disposal method 4 and 5, respectively.
315 RefPtr<SharedBuffer> data =
316 ReadFile(kDecodersTestingDir, "invalid-disposal-method.gif");
317 ASSERT_TRUE(data.Get());
318 decoder->SetData(data.Get(), true);
319
320 EXPECT_EQ(2u, decoder->FrameCount());
321 // Disposal method 4 is converted to ImageFrame::DisposeOverwritePrevious.
322 EXPECT_EQ(ImageFrame::kDisposeOverwritePrevious,
323 decoder->FrameBufferAtIndex(0)->GetDisposalMethod());
324 // Disposal method 5 is ignored.
325 EXPECT_EQ(ImageFrame::kDisposeNotSpecified,
326 decoder->FrameBufferAtIndex(1)->GetDisposalMethod());
327 }
328
329 TEST(GIFImageDecoderTest, firstFrameHasGreaterSizeThanScreenSize) { 298 TEST(GIFImageDecoderTest, firstFrameHasGreaterSizeThanScreenSize) {
330 RefPtr<SharedBuffer> full_data = ReadFile( 299 RefPtr<SharedBuffer> full_data = ReadFile(
331 kDecodersTestingDir, "first-frame-has-greater-size-than-screen-size.gif"); 300 kDecodersTestingDir, "first-frame-has-greater-size-than-screen-size.gif");
332 ASSERT_TRUE(full_data.Get()); 301 ASSERT_TRUE(full_data.Get());
333 302
334 std::unique_ptr<ImageDecoder> decoder; 303 std::unique_ptr<ImageDecoder> decoder;
335 IntSize frame_size; 304 IntSize frame_size;
336 305
337 // Compute hashes when the file is truncated. 306 // Compute hashes when the file is truncated.
338 for (size_t i = 1; i <= full_data->size(); ++i) { 307 for (size_t i = 1; i <= full_data->size(); ++i) {
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 348
380 // Partially decoded frame => the frame alpha type is unknown and should 349 // Partially decoded frame => the frame alpha type is unknown and should
381 // reflect the requested format. 350 // reflect the requested format.
382 premul_decoder->SetData(partial_data.Get(), false); 351 premul_decoder->SetData(partial_data.Get(), false);
383 ASSERT_TRUE(premul_decoder->FrameCount()); 352 ASSERT_TRUE(premul_decoder->FrameCount());
384 unpremul_decoder->SetData(partial_data.Get(), false); 353 unpremul_decoder->SetData(partial_data.Get(), false);
385 ASSERT_TRUE(unpremul_decoder->FrameCount()); 354 ASSERT_TRUE(unpremul_decoder->FrameCount());
386 ImageFrame* premul_frame = premul_decoder->FrameBufferAtIndex(0); 355 ImageFrame* premul_frame = premul_decoder->FrameBufferAtIndex(0);
387 EXPECT_TRUE(premul_frame && 356 EXPECT_TRUE(premul_frame &&
388 premul_frame->GetStatus() != ImageFrame::kFrameComplete); 357 premul_frame->GetStatus() != ImageFrame::kFrameComplete);
389 EXPECT_EQ(premul_frame->Bitmap().alphaType(), kPremul_SkAlphaType); 358 EXPECT_EQ(kPremul_SkAlphaType, premul_frame->Bitmap().alphaType());
390 ImageFrame* unpremul_frame = unpremul_decoder->FrameBufferAtIndex(0); 359 ImageFrame* unpremul_frame = unpremul_decoder->FrameBufferAtIndex(0);
391 EXPECT_TRUE(unpremul_frame && 360 EXPECT_TRUE(unpremul_frame &&
392 unpremul_frame->GetStatus() != ImageFrame::kFrameComplete); 361 unpremul_frame->GetStatus() != ImageFrame::kFrameComplete);
393 EXPECT_EQ(unpremul_frame->Bitmap().alphaType(), kUnpremul_SkAlphaType); 362 EXPECT_EQ(kUnpremul_SkAlphaType, unpremul_frame->Bitmap().alphaType());
394 363
395 // Fully decoded frame => the frame alpha type is known (opaque). 364 // Fully decoded frame => the frame alpha type is known (opaque).
396 premul_decoder->SetData(full_data.Get(), true); 365 premul_decoder->SetData(full_data.Get(), true);
397 ASSERT_TRUE(premul_decoder->FrameCount()); 366 ASSERT_TRUE(premul_decoder->FrameCount());
398 unpremul_decoder->SetData(full_data.Get(), true); 367 unpremul_decoder->SetData(full_data.Get(), true);
399 ASSERT_TRUE(unpremul_decoder->FrameCount()); 368 ASSERT_TRUE(unpremul_decoder->FrameCount());
400 premul_frame = premul_decoder->FrameBufferAtIndex(0); 369 premul_frame = premul_decoder->FrameBufferAtIndex(0);
401 EXPECT_TRUE(premul_frame && 370 EXPECT_TRUE(premul_frame &&
402 premul_frame->GetStatus() == ImageFrame::kFrameComplete); 371 premul_frame->GetStatus() == ImageFrame::kFrameComplete);
403 EXPECT_EQ(premul_frame->Bitmap().alphaType(), kOpaque_SkAlphaType); 372 EXPECT_EQ(kOpaque_SkAlphaType, premul_frame->Bitmap().alphaType());
404 unpremul_frame = unpremul_decoder->FrameBufferAtIndex(0); 373 unpremul_frame = unpremul_decoder->FrameBufferAtIndex(0);
405 EXPECT_TRUE(unpremul_frame && 374 EXPECT_TRUE(unpremul_frame &&
406 unpremul_frame->GetStatus() == ImageFrame::kFrameComplete); 375 unpremul_frame->GetStatus() == ImageFrame::kFrameComplete);
407 EXPECT_EQ(unpremul_frame->Bitmap().alphaType(), kOpaque_SkAlphaType); 376 EXPECT_EQ(kOpaque_SkAlphaType, unpremul_frame->Bitmap().alphaType());
408 } 377 }
409 378
410 namespace { 379 namespace {
411 // Needed to exercise ImageDecoder::setMemoryAllocator, but still does the 380 // Needed to exercise ImageDecoder::setMemoryAllocator, but still does the
412 // default allocation. 381 // default allocation.
413 class Allocator final : public SkBitmap::Allocator { 382 class Allocator final : public SkBitmap::Allocator {
414 bool allocPixelRef(SkBitmap* dst, SkColorTable* ctable) override { 383 bool allocPixelRef(SkBitmap* dst, SkColorTable* ctable) override {
415 return dst->tryAllocPixels(ctable); 384 return dst->tryAllocPixels(ctable);
416 } 385 }
417 }; 386 };
(...skipping 13 matching lines...) Expand all
431 EXPECT_EQ(1u, decoder->FrameCount()); 400 EXPECT_EQ(1u, decoder->FrameCount());
432 ImageFrame* frame = decoder->FrameBufferAtIndex(0); 401 ImageFrame* frame = decoder->FrameBufferAtIndex(0);
433 decoder->SetMemoryAllocator(nullptr); 402 decoder->SetMemoryAllocator(nullptr);
434 403
435 ASSERT_TRUE(frame); 404 ASSERT_TRUE(frame);
436 EXPECT_EQ(IntRect(IntPoint(), decoder->Size()), frame->OriginalFrameRect()); 405 EXPECT_EQ(IntRect(IntPoint(), decoder->Size()), frame->OriginalFrameRect());
437 EXPECT_FALSE(frame->HasAlpha()); 406 EXPECT_FALSE(frame->HasAlpha());
438 } 407 }
439 408
440 } // namespace blink 409 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698