Move gif image decoder to SkCodec

skia/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//build/config/ui.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//printing/features/features.gni")
 import("//testing/test.gni")
 import("//third_party/skia/gn/shared_sources.gni")
@@ skipping 11 matching lines @@
 declare_args() {
   skia_whitelist_serialized_typefaces = false
 }
 
 # External-facing config for dependent code.
 config("skia_config") {
   include_dirs = [
     "config",
     "ext",
     "//third_party/skia/include/c",
+    "//third_party/skia/include/codec",
     "//third_party/skia/include/config",
     "//third_party/skia/include/core",
     "//third_party/skia/include/effects",
     "//third_party/skia/include/images",
     "//third_party/skia/include/lazy",
     "//third_party/skia/include/pathops",
     "//third_party/skia/include/pdf",
     "//third_party/skia/include/pipe",
     "//third_party/skia/include/ports",
     "//third_party/skia/include/utils",
@@ skipping 43 matching lines @@
 }
 
 # Internal-facing config for Skia library code.
 config("skia_library_config") {
   # These include directories are only included for Skia code and are not
   # exported to dependents. It's not clear if this is on purpose, but this
   # matches the GYP build.
   include_dirs = [
     "//third_party/skia/include/private",
     "//third_party/skia/include/client/android",
+    "//third_party/skia/src/codec",
     "//third_party/skia/src/core",
     "//third_party/skia/src/image",
     "//third_party/skia/src/opts",
     "//third_party/skia/src/pdf",
     "//third_party/skia/src/ports",
     "//third_party/skia/src/sfnt",
     "//third_party/skia/src/utils",
     "//third_party/skia/src/lazy",
   ]
   if (is_mac || is_ios) {
@@ skipping 115 matching lines @@
   if (!is_ios) {
     sources += [ "ext/platform_canvas.cc" ]
   }
   if (!is_ios && (current_cpu == "x86" || current_cpu == "x64")) {
     sources += [ "ext/convolver_SSE2.cc" ]
   } else if (current_cpu == "mipsel" && mips_dsp_rev >= 2) {
     sources += [ "ext/convolver_mips_dspr2.cc" ]
   }
 
   # The skia gypi values are relative to the skia_dir, so we need to rebase.
+  sources += skia_codec_sources

[cblume, 2016/12/19 08:04:03]

I had put the required .cpp files inside a Skia build file, which defined
skia_codec_sources.

However, code review comments on that (seen here:
https://skia-review.googlesource.com/c/6205/ ) made it clear that we should
instead have the files be listed out in Chrome.

   sources += skia_core_sources
   sources += skia_effects_sources
   sources += skia_utils_sources
   sources += [
     "//third_party/skia/src/fonts/SkFontMgr_indirect.cpp",
     "//third_party/skia/src/fonts/SkRemotableFontMgr.cpp",
     "//third_party/skia/src/ports/SkFontConfigInterface.cpp",
     "//third_party/skia/src/ports/SkFontConfigInterface_direct.cpp",
     "//third_party/skia/src/ports/SkFontConfigInterface_direct_factory.cpp",
     "//third_party/skia/src/ports/SkFontHost_FreeType.cpp",
@@ skipping 478 matching lines @@
 
     deps = [
       ":skia",
       "//base",
       "//base/test:test_support",
       "//build/config/sanitizers:deps",
       "//build/win:default_exe_manifest",
     ]
   }
 }