Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(899)

Issue 2565313002: Revert of Delay Input.dispatchKeyEvent response until after key event ack. (Closed)

Created:
4 years ago by gab
Modified:
4 years ago
CC:
chromium-reviews, caseq+blink_chromium.org, jam, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, darin-cc_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org, Alexei Svitkine (slow), Charlie Harrison
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Delay Input.dispatchKeyEvent response until after key event ack. (patchset #16 id:300001 of https://codereview.chromium.org/2387353004/ ) Reason for revert: Tentative revert for: Failed steps failed chrome_public_test_apk on android failed content_browsertests on android https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29?numbuilds=200 as of this CL (and 2 others which are mere renames + don't touch content so suspecting this one from the 3: https://chromium.googlesource.com/chromium/src/+log/b671a5234f41f1784bd261a7c1eb6010434cd2c2..92aad3c0c15d18263af3e5ce0dad525c0b063297?pretty=fuller&n=10000) No logs from failures on Android bot unfortunately :-(... Don't understand why it would have passed CQ and not waterfall but still can't see what else in range could be at fault, sorry.. Original issue's description: > Delay Input.dispatchKeyEvent response until after key event ack. > > BUG=chromedriver:1506 > > Review-Url: https://codereview.chromium.org/2387353004 TBR=tdresser@chromium.org,dtapuska@chromium.org,dgozman@chromium.org,pfeldman@chromium.org,samuong@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=673218, chromedriver:1506 Committed: https://crrev.com/b559a0948b325b01789c01e44ee89719df93feb4 Cr-Commit-Position: refs/heads/master@{#437888}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -189 lines) Patch
M content/browser/devtools/protocol/devtools_protocol_browsertest.cc View 4 chunks +10 lines, -78 lines 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.h View 5 chunks +4 lines, -23 lines 0 comments Download
M content/browser/devtools/protocol/input_handler.cc View 7 chunks +0 lines, -65 lines 0 comments Download
M content/browser/devtools/render_frame_devtools_agent_host.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 5 chunks +0 lines, -10 lines 0 comments Download
M content/public/browser/render_widget_host.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/public/test/browser_test_utils.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/test/browser_test_utils.cc View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 30 (17 generated)
gab
Created Revert of Delay Input.dispatchKeyEvent response until after key event ack.
4 years ago (2016-12-12 05:45:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565313002/1
4 years ago (2016-12-12 05:45:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565313002/1
4 years ago (2016-12-12 05:49:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/196914)
4 years ago (2016-12-12 07:20:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565313002/1
4 years ago (2016-12-12 07:41:05 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/196943)
4 years ago (2016-12-12 09:17:37 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565313002/1
4 years ago (2016-12-12 09:21:40 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/196985)
4 years ago (2016-12-12 11:13:02 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565313002/1
4 years ago (2016-12-12 11:19:22 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/197030)
4 years ago (2016-12-12 12:53:53 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565313002/1
4 years ago (2016-12-12 15:33:14 UTC) #25
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 16:35:30 UTC) #28
commit-bot: I haz the power
4 years ago (2016-12-12 16:37:40 UTC) #30
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b559a0948b325b01789c01e44ee89719df93feb4
Cr-Commit-Position: refs/heads/master@{#437888}

Powered by Google App Engine
This is Rietveld 408576698