Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2565303003: 🎄 Fix resource_sizes.py when no pak files exist. (Closed)

Created:
4 years ago by agrieve
Modified:
4 years ago
Reviewers:
estevenson
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix resource_sizes.py when no pak files exist. It was crashing due to StopIteration exception BUG=671803 Committed: https://crrev.com/bc2287b04358cea1f46f60ae777dd170c2520afa Cr-Commit-Position: refs/heads/master@{#437945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M build/android/resource_sizes.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
agrieve
On 2016/12/12 19:42:41, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:estevenson@chromium.org
4 years ago (2016-12-12 19:43:00 UTC) #4
estevenson
On 2016/12/12 19:43:00, agrieve wrote: > On 2016/12/12 19:42:41, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
4 years ago (2016-12-12 19:46:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565303003/1
4 years ago (2016-12-12 21:46:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 23:13:41 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 23:17:20 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc2287b04358cea1f46f60ae777dd170c2520afa
Cr-Commit-Position: refs/heads/master@{#437945}

Powered by Google App Engine
This is Rietveld 408576698