Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2565293002:
Remove unnecessary "export" in PowerMonitorBroadcastSource (Closed)
DescriptionRemove unnecessary "export" in PowerMonitorBroadcastSource
No need to export PowerMonitorBroadcastSource.
BUG = 647247
Committed: https://crrev.com/7256d7f270a7b3a7a64636bb9e9cbcf0a5fcd484
Cr-Commit-Position: refs/heads/master@{#437859}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Remove unnecessary "export" in PowerMonitorBroadcastSource #
Messages
Total messages: 20 (14 generated)
The CQ bit was checked by ke.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
ke.he@intel.com changed reviewers: + blundell@chromium.org, leon.han@intel.com
Hi, blundell@, fixed a mistake we didn't aware before. PTAL. Thanks. Thanks Leon find this error:)
lgtm https://codereview.chromium.org/2565293002/diff/1/device/power_monitor/public... File device/power_monitor/public/cpp/BUILD.gn (right): https://codereview.chromium.org/2565293002/diff/1/device/power_monitor/public... device/power_monitor/public/cpp/BUILD.gn:13: defines = [ "DEVICE_POWER_MONITOR_IMPLEMENTATION" ] you can get rid of this as well, right?
The CQ bit was checked by ke.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2565293002/diff/1/device/power_monitor/public... File device/power_monitor/public/cpp/BUILD.gn (right): https://codereview.chromium.org/2565293002/diff/1/device/power_monitor/public... device/power_monitor/public/cpp/BUILD.gn:13: defines = [ "DEVICE_POWER_MONITOR_IMPLEMENTATION" ] On 2016/12/12 11:57:07, blundell wrote: > you can get rid of this as well, right? Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by ke.he@intel.com
The patchset sent to the CQ was uploaded after l-g-t-m from blundell@chromium.org Link to the patchset: https://codereview.chromium.org/2565293002/#ps20001 (title: "Remove unnecessary "export" in PowerMonitorBroadcastSource")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481548971985650,
"parent_rev": "0a96b0e4e751ae5206b0401cd53bf980028c0646", "commit_rev":
"5ed3516116694429c59b389ea27013d537046036"}
Message was sent while issue was closed.
Description was changed from ========== Remove unnecessary "export" in PowerMonitorBroadcastSource No need to export PowerMonitorBroadcastSource. BUG = 647247 ========== to ========== Remove unnecessary "export" in PowerMonitorBroadcastSource No need to export PowerMonitorBroadcastSource. BUG = 647247 Review-Url: https://codereview.chromium.org/2565293002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Remove unnecessary "export" in PowerMonitorBroadcastSource No need to export PowerMonitorBroadcastSource. BUG = 647247 Review-Url: https://codereview.chromium.org/2565293002 ========== to ========== Remove unnecessary "export" in PowerMonitorBroadcastSource No need to export PowerMonitorBroadcastSource. BUG = 647247 Committed: https://crrev.com/7256d7f270a7b3a7a64636bb9e9cbcf0a5fcd484 Cr-Commit-Position: refs/heads/master@{#437859} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7256d7f270a7b3a7a64636bb9e9cbcf0a5fcd484 Cr-Commit-Position: refs/heads/master@{#437859} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
