Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2565233005: Marking flaky tests in fast as such. (Closed)

Created:
4 years ago by nainar
Modified:
4 years ago
Reviewers:
sashab
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Marking flaky tests in fast as such. This patch marks a few tests that are being flaky as so. Will try to find owners for these tests. BUG=673632 Committed: https://crrev.com/e161fe6c20a2e06ed4862ed2ee3ce119330f0475 Cr-Commit-Position: refs/heads/master@{#438071}

Patch Set 1 #

Patch Set 2 : change bug numbers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (11 generated)
nainar
PTAL? Thanks!
4 years ago (2016-12-13 03:24:23 UTC) #3
sashab
Please file bug & attach to patch. Otherwise lgtm :)
4 years ago (2016-12-13 03:25:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565233005/1
4 years ago (2016-12-13 03:56:32 UTC) #8
sashab
Naina you didn't put BUG= so I cancelled the commit :P
4 years ago (2016-12-13 04:14:42 UTC) #10
sashab
Lgtm again 8-) for real this time
4 years ago (2016-12-13 04:22:14 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565233005/20001
4 years ago (2016-12-13 04:38:54 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 05:55:56 UTC) #17
commit-bot: I haz the power
4 years ago (2016-12-13 05:58:00 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e161fe6c20a2e06ed4862ed2ee3ce119330f0475
Cr-Commit-Position: refs/heads/master@{#438071}

Powered by Google App Engine
This is Rietveld 408576698