Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2565173005: Make DataUseMeasurementTest.UserNotUserTest pass with lld/win. (Closed)

Created:
4 years ago by Nico
Modified:
4 years ago
Reviewers:
ruiu
CC:
chromium-reviews, Raj
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DataUseMeasurementTest.UserNotUserTest pass with lld/win. BUG=668207 TBR=rnk Committed: https://crrev.com/501fb6dbe391965bd11219475fcb1980491312f4 Cr-Commit-Position: refs/heads/master@{#437977}

Patch Set 1 #

Patch Set 2 : fix comment typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M components/data_use_measurement/core/data_use_measurement_unittest.cc View 1 1 chunk +14 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (14 generated)
Nico
4 years ago (2016-12-12 22:29:27 UTC) #3
ruiu
On 2016/12/12 22:29:27, Nico wrote: LGTM
4 years ago (2016-12-12 22:41:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565173005/20001
4 years ago (2016-12-12 22:49:06 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/324171)
4 years ago (2016-12-12 23:58:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565173005/20001
4 years ago (2016-12-13 01:16:39 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 01:25:00 UTC) #19
commit-bot: I haz the power
4 years ago (2016-12-13 01:29:53 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/501fb6dbe391965bd11219475fcb1980491312f4
Cr-Commit-Position: refs/heads/master@{#437977}

Powered by Google App Engine
This is Rietveld 408576698