Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 2565173004: [heap] Special handling for small heaps in eager finalization of (Closed)

Created:
4 years ago by ulan
Modified:
4 years ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Special handling for small heaps in eager finalization of incremental marking. BUG=chromium:671994 Committed: https://crrev.com/ca9209d705f5757111ba079aef7ad98b880fc0f8 Cr-Commit-Position: refs/heads/master@{#41666}

Patch Set 1 #

Patch Set 2 : fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M src/heap/heap.h View 1 chunk +6 lines, -2 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
Michael Lippautz
lgtm
4 years ago (2016-12-12 19:37:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565173004/1
4 years ago (2016-12-12 20:38:15 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/17655) v8_linux_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years ago (2016-12-12 21:02:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565173004/20001
4 years ago (2016-12-13 09:56:58 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-13 10:25:41 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-13 10:26:02 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca9209d705f5757111ba079aef7ad98b880fc0f8
Cr-Commit-Position: refs/heads/master@{#41666}

Powered by Google App Engine
This is Rietveld 408576698