|
|
Description[interpreter] Add check for max number of operands.
BUG=
Committed: https://crrev.com/9c9c945f18bbdbdce48b56813e1402d09e2f731e
Cr-Commit-Position: refs/heads/master@{#41630}
Patch Set 1 #
Messages
Total messages: 22 (12 generated)
The CQ bit was checked by franzih@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
franzih@chromium.org changed reviewers: + jarin@chromium.org
Hi Jaro, I added a static_assert for the maximum number of operands so the next person doesn't trip over this. PTAL. Thanks, Franzi
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Good idea! I am now wondering whether bumping kMaxOperands fixes your problems(?). lgtm.
The CQ bit was checked by franzih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30375)
franzih@chromium.org changed reviewers: + bmeurer@chromium.org
Hi Benedikt, Can you have a look please (need an owner). Thanks, Franzi
Thanks for adding this (after running into this), should help other's to avoid the same pitfall in the future! LGTM. BTW.: Ross, Mythri and Leszek are usually good suspects for interpreter reviews.
On 2016/12/10 22:40:34, Jarin wrote: > Good idea! I am now wondering whether bumping kMaxOperands fixes your > problems(?). It did. But I think we should redesign the inputs a bit and just have one immediate flags input that controls both the enumerable vs non-enumerable attributes and the set-function-name behavior.
The CQ bit was checked by franzih@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 1, "attempt_start_ts": 1481476157262670, "parent_rev": "de3db01c5bfc40292fbabcee5ebb53e2bd154266", "commit_rev": "086f1a4e9af22890261502197326f24eae83014f"}
Message was sent while issue was closed.
Description was changed from ========== [interpreter] Add check for max number of operands. BUG= ========== to ========== [interpreter] Add check for max number of operands. BUG= Review-Url: https://codereview.chromium.org/2565093003 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [interpreter] Add check for max number of operands. BUG= Review-Url: https://codereview.chromium.org/2565093003 ========== to ========== [interpreter] Add check for max number of operands. BUG= Committed: https://crrev.com/9c9c945f18bbdbdce48b56813e1402d09e2f731e Cr-Commit-Position: refs/heads/master@{#41630} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9c9c945f18bbdbdce48b56813e1402d09e2f731e Cr-Commit-Position: refs/heads/master@{#41630} |