Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2565093003: [interpreter] Add check for max number of operands. (Closed)

Created:
4 years ago by Franzi
Modified:
4 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Add check for max number of operands. BUG= Committed: https://crrev.com/9c9c945f18bbdbdce48b56813e1402d09e2f731e Cr-Commit-Position: refs/heads/master@{#41630}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/interpreter/bytecode-array-builder.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (12 generated)
Franzi
Hi Jaro, I added a static_assert for the maximum number of operands so the next ...
4 years ago (2016-12-10 21:39:32 UTC) #4
Jarin
Good idea! I am now wondering whether bumping kMaxOperands fixes your problems(?). lgtm.
4 years ago (2016-12-10 22:40:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565093003/1
4 years ago (2016-12-10 23:11:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30375)
4 years ago (2016-12-10 23:14:25 UTC) #11
Franzi
Hi Benedikt, Can you have a look please (need an owner). Thanks, Franzi
4 years ago (2016-12-11 07:24:04 UTC) #13
Benedikt Meurer
Thanks for adding this (after running into this), should help other's to avoid the same ...
4 years ago (2016-12-11 12:09:51 UTC) #14
Benedikt Meurer
On 2016/12/10 22:40:34, Jarin wrote: > Good idea! I am now wondering whether bumping kMaxOperands ...
4 years ago (2016-12-11 12:10:46 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565093003/1
4 years ago (2016-12-11 17:09:28 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-11 17:11:16 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-11 17:25:02 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9c9c945f18bbdbdce48b56813e1402d09e2f731e
Cr-Commit-Position: refs/heads/master@{#41630}

Powered by Google App Engine
This is Rietveld 408576698