Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2565093002:
[Mac] Fix unit_tests build in 10.12 SDK. (Closed)
|
Created:
4 years ago by dhna Modified:
4 years ago Reviewers:
Robert Sesek CC:
chromium-reviews, mac-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Mac] Fix unit_tests build in 10.12 SDK.
exception_processor_unittest.mm:
error: null passed to a callee that requires a non-null argument
Committed: https://crrev.com/588d172814d776f14ca6256725579423fa3519f8
Cr-Commit-Position: refs/heads/master@{#437917}
Patch Set 1 #
Messages
Total messages: 19 (10 generated)
corona10@gmail.com changed reviewers: + rsesek@chromium.org
rsesek@ PTAL
LGTM, but please improve the CL description. Something like this: """ [Mac] Fix unit_tests build <in what configuration -- 10.12 SDK?>. exception_processor_unittest.mm: <build error. """
Description was changed from ========== unit_test build failed with this message. error: null passed to a callee that requires a non-null argument. ========== to ========== [Mac] Fix unit_tests build in 10.12 SDK. exception_processor_unittest.mm: <build error.> ==========
On 2016/12/12 17:13:55, Robert Sesek wrote: > LGTM, but please improve the CL description. Something like this: > > """ > [Mac] Fix unit_tests build <in what configuration -- 10.12 SDK?>. > > exception_processor_unittest.mm: <build error. > """ Thanks!!
The CQ bit was checked by corona10@gmail.com
The CQ bit was unchecked by rsesek@chromium.org
On 2016/12/12 19:37:52, dhna wrote: > On 2016/12/12 17:13:55, Robert Sesek wrote: > > LGTM, but please improve the CL description. Something like this: > > > > """ > > [Mac] Fix unit_tests build <in what configuration -- 10.12 SDK?>. > > > > exception_processor_unittest.mm: <build error. > > """ > > Thanks!! Please actually put the build error in the CL description.
Description was changed from ========== [Mac] Fix unit_tests build in 10.12 SDK. exception_processor_unittest.mm: <build error.> ========== to ========== [Mac] Fix unit_tests build in 10.12 SDK. exception_processor_unittest.mm: <error: null passed to a callee that requires a non-null argument> ==========
On 2016/12/12 19:38:36, Robert Sesek wrote: > On 2016/12/12 19:37:52, dhna wrote: > > On 2016/12/12 17:13:55, Robert Sesek wrote: > > > LGTM, but please improve the CL description. Something like this: > > > > > > """ > > > [Mac] Fix unit_tests build <in what configuration -- 10.12 SDK?>. > > > > > > exception_processor_unittest.mm: <build error. > > > """ > > > > Thanks!! > > Please actually put the build error in the CL description. rsesek@ Thank you for check my update. I update description. Is it correct?
Description was changed from ========== [Mac] Fix unit_tests build in 10.12 SDK. exception_processor_unittest.mm: <error: null passed to a callee that requires a non-null argument> ========== to ========== [Mac] Fix unit_tests build in 10.12 SDK. exception_processor_unittest.mm: error: null passed to a callee that requires a non-null argument ==========
lgtm, thanks
The CQ bit was checked by corona10@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1481572128311650, "parent_rev":
"ebe8681c966a9eae760955152301ebae1d3dddb5", "commit_rev":
"9b4fe32e2158453c75ad66f623f9daf8e9053887"}
Message was sent while issue was closed.
Description was changed from ========== [Mac] Fix unit_tests build in 10.12 SDK. exception_processor_unittest.mm: error: null passed to a callee that requires a non-null argument ========== to ========== [Mac] Fix unit_tests build in 10.12 SDK. exception_processor_unittest.mm: error: null passed to a callee that requires a non-null argument Review-Url: https://codereview.chromium.org/2565093002 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Mac] Fix unit_tests build in 10.12 SDK. exception_processor_unittest.mm: error: null passed to a callee that requires a non-null argument Review-Url: https://codereview.chromium.org/2565093002 ========== to ========== [Mac] Fix unit_tests build in 10.12 SDK. exception_processor_unittest.mm: error: null passed to a callee that requires a non-null argument Committed: https://crrev.com/588d172814d776f14ca6256725579423fa3519f8 Cr-Commit-Position: refs/heads/master@{#437917} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/588d172814d776f14ca6256725579423fa3519f8 Cr-Commit-Position: refs/heads/master@{#437917} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
