Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 2565083002: [Download Home] Remove -> Delete (Closed)

Created:
4 years ago by gone
Modified:
4 years ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

[Download Home] Remove -> Delete Change message to show that clicking on a trash can actually deletes items instead of just removes them, even though the operation is "remove" by the DownloadHistory backend. BUG=666292 TBR=twellington@chromium.org Original-Review-Url: https://codereview.chromium.org/2564053003 Original-Cr-Commit-Position: refs/heads/master@{#437685} Committed: https://chromium.googlesource.com/chromium/src/+/eb5e22be192ab7167bb0cfcb232715fefff70018

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/res/menu/download_manager_menu.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
gone
4 years ago (2016-12-10 00:59:16 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
eb5e22be192ab7167bb0cfcb232715fefff70018 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698