Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2564053003: [Download Home] Remove -> Delete (Closed)

Created:
4 years ago by gone
Modified:
4 years ago
Reviewers:
Theresa
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Download Home] Remove -> Delete Change message to show that clicking on a trash can actually deletes items instead of just removes them, even though the operation is "remove" by the DownloadHistory backend. BUG=666292 Committed: https://crrev.com/adcd6b19c1830e2750bf0e0ca4de4c542ffbacbe Cr-Commit-Position: refs/heads/master@{#437685}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/android/java/res/menu/download_manager_menu.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
gone
4 years ago (2016-12-09 19:44:31 UTC) #3
Theresa
lgtm
4 years ago (2016-12-09 21:40:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564053003/1
4 years ago (2016-12-09 21:59:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 23:23:54 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 14:58:10 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/adcd6b19c1830e2750bf0e0ca4de4c542ffbacbe
Cr-Commit-Position: refs/heads/master@{#437685}

Powered by Google App Engine
This is Rietveld 408576698