Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

Issue 2565023002: Use GURLs in Physical Web data source (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
index 77f3d21c0d075c64b3c1aff55d3db819ecedf7ec..38e0f3df3c308d253b15114be63880d35f74fbe4 100644
--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
@@ -6,7 +6,6 @@
#define COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTIONS_PROVIDER_H_
#include <set>
-#include <string>
vitaliii 2016/12/12 06:56:38 Please leave this. There are other places where th
cco3 2016/12/12 19:00:31 Done.
#include <vector>
#include "base/callback_forward.h"
@@ -18,6 +17,7 @@
#include "components/ntp_snippets/content_suggestions_provider.h"
#include "components/physical_web/data_source/physical_web_data_source.h"
#include "components/physical_web/data_source/physical_web_listener.h"
+#include "url/gurl.h"
Marc Treib 2016/12/12 10:20:25 optional: Could just forward-declare class GURL;
cco3 2016/12/12 19:00:31 Done.
namespace ntp_snippets {
@@ -72,10 +72,9 @@ class PhysicalWebPageSuggestionsProvider
const base::DictionaryValue& page) const;
// PhysicalWebListener implementation.
- void OnFound(const std::string& url) override;
- void OnLost(const std::string& url) override;
- void OnDistanceChanged(const std::string& url,
- double distance_estimate) override;
+ void OnFound(const GURL& url) override;
+ void OnLost(const GURL& url) override;
+ void OnDistanceChanged(const GURL& url, double distance_estimate) override;
CategoryStatus category_status_;
const Category provided_category_;

Powered by Google App Engine
This is Rietveld 408576698