Use GURLs in Physical Web data source

components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTIONS_PROVIDER_H_
 #define COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTIONS_PROVIDER_H_
 
 #include <set>
-#include <string>

[vitaliii, 2016/12/12 06:56:38]

Please leave this.
There are other places where the std::string is used.

[cco3, 2016/12/12 19:00:31]

Done.

 #include <vector>
 
 #include "base/callback_forward.h"
 #include "base/values.h"
 #include "components/ntp_snippets/category.h"
 #include "components/ntp_snippets/category_factory.h"
 #include "components/ntp_snippets/category_status.h"
 #include "components/ntp_snippets/content_suggestion.h"
 #include "components/ntp_snippets/content_suggestions_provider.h"
 #include "components/physical_web/data_source/physical_web_data_source.h"
 #include "components/physical_web/data_source/physical_web_listener.h"
+#include "url/gurl.h"

[Marc Treib, 2016/12/12 10:20:25]

optional: Could just forward-declare
class GURL;

[cco3, 2016/12/12 19:00:31]

Done.

 
 namespace ntp_snippets {
 
 // Provides content suggestions from the Physical Web Service.
 class PhysicalWebPageSuggestionsProvider
     : public ContentSuggestionsProvider,
       public physical_web::PhysicalWebListener {
  public:
   PhysicalWebPageSuggestionsProvider(
       ContentSuggestionsProvider::Observer* observer,
@@ skipping 34 matching lines @@
   // are obtained from Physical Web data source.
   std::vector<ContentSuggestion> GetMostRecentPhysicalWebPagesWithFilter(
       int max_count,
       const std::set<std::string>& excluded_ids);
 
   // Converts an Physical Web page to a ContentSuggestion.
   ContentSuggestion ConvertPhysicalWebPage(
       const base::DictionaryValue& page) const;
 
   // PhysicalWebListener implementation.
-  void OnFound(const std::string& url) override;
-  void OnLost(const std::string& url) override;
-  void OnDistanceChanged(const std::string& url,
-                         double distance_estimate) override;
+  void OnFound(const GURL& url) override;
+  void OnLost(const GURL& url) override;
+  void OnDistanceChanged(const GURL& url, double distance_estimate) override;
 
   CategoryStatus category_status_;
   const Category provided_category_;
   physical_web::PhysicalWebDataSource* physical_web_data_source_;
 
   DISALLOW_COPY_AND_ASSIGN(PhysicalWebPageSuggestionsProvider);
 };
 
 }  // namespace ntp_snippets
 
 #endif  // COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTIONS_PROVIDER_H_