Revert of Change ExecLinkWrapper to not buffer all tool output

Revert of Change ExecLinkWrapper to not buffer all tool output (patchset #2 id:20001 of https://codereview.chromium.org/2558153002/ )

Reason for revert:
Reverting under suspicion for crbug.com/672841.

Original issue's description:
> Change ExecLinkWrapper to not buffer all tool output
>
> /verbose linking of chrome.dll creates over one GB of output. This
> causes ExecLinkWrapper to consume over two GB of memory which leads to
> an OOM failure in the 32-bit depot_tools python, and the loss of all
> of the valuable output. This change modifies ExecLinkWrapper to
> process the output one line at a time, thus avoiding the OOM.
>
> I've tested that this handles the 1.1 GB of output which the previous
> version of this function failed on and I've visually confirmed that the
> output looks the same - no extraneous blank lines, for instance, when
> displaying warnings, errors, or 1.9 million lines of verbose output.
>
> I also verified that the script stays idle when waiting for output -
> blocking on .readline().
>
> BUG=672182
>
> Committed: https://crrev.com/5d0d1b0bf01acb3ebe3a5ef27ebf2f3180ab1d1d
> Cr-Commit-Position: refs/heads/master@{#437126}

TBR=brucedawson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=672182
Committed: https://crrev.com/8e0b754f6372a0d5fc6d1c1df1597dfb9ac877ed
Cr-Commit-Position: refs/heads/master@{#437572}

[scottmg, 2016-12-09 16:14:50]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-12-09 16:14:51]

Created Revert of Change ExecLinkWrapper to not buffer all tool output

[commit-bot: I haz the power, 2016-12-09 16:15:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 17:20:23]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481300090901290, "parent_rev":
"88835793eac7a3450b1118e4bf0319bbb348dc52", "commit_rev":
"85791b94c0d34d5e711b6a0085577934b940e1ee"}

[commit-bot: I haz the power, 2016-12-09 17:20:51]

Description was changed from

==========
Revert of Change ExecLinkWrapper to not buffer all tool output (patchset #2
id:20001 of https://codereview.chromium.org/2558153002/ )

Reason for revert:
Reverting under suspicion for crbug.com/672841.

Original issue's description:
> Change ExecLinkWrapper to not buffer all tool output
> 
> /verbose linking of chrome.dll creates over one GB of output. This
> causes ExecLinkWrapper to consume over two GB of memory which leads to
> an OOM failure in the 32-bit depot_tools python, and the loss of all
> of the valuable output. This change modifies ExecLinkWrapper to
> process the output one line at a time, thus avoiding the OOM.
> 
> I've tested that this handles the 1.1 GB of output which the previous
> version of this function failed on and I've visually confirmed that the
> output looks the same - no extraneous blank lines, for instance, when
> displaying warnings, errors, or 1.9 million lines of verbose output.
> 
> I also verified that the script stays idle when waiting for output -
> blocking on .readline().
> 
> BUG=672182
> 
> Committed: https://crrev.com/5d0d1b0bf01acb3ebe3a5ef27ebf2f3180ab1d1d
> Cr-Commit-Position: refs/heads/master@{#437126}

TBR=brucedawson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=672182
==========

to

==========
Revert of Change ExecLinkWrapper to not buffer all tool output (patchset #2
id:20001 of https://codereview.chromium.org/2558153002/ )

Reason for revert:
Reverting under suspicion for crbug.com/672841.

Original issue's description:
> Change ExecLinkWrapper to not buffer all tool output
> 
> /verbose linking of chrome.dll creates over one GB of output. This
> causes ExecLinkWrapper to consume over two GB of memory which leads to
> an OOM failure in the 32-bit depot_tools python, and the loss of all
> of the valuable output. This change modifies ExecLinkWrapper to
> process the output one line at a time, thus avoiding the OOM.
> 
> I've tested that this handles the 1.1 GB of output which the previous
> version of this function failed on and I've visually confirmed that the
> output looks the same - no extraneous blank lines, for instance, when
> displaying warnings, errors, or 1.9 million lines of verbose output.
> 
> I also verified that the script stays idle when waiting for output -
> blocking on .readline().
> 
> BUG=672182
> 
> Committed: https://crrev.com/5d0d1b0bf01acb3ebe3a5ef27ebf2f3180ab1d1d
> Cr-Commit-Position: refs/heads/master@{#437126}

TBR=brucedawson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=672182

Review-Url: https://codereview.chromium.org/2564893002
==========

[commit-bot: I haz the power, 2016-12-09 17:20:51]

Committed patchset #1 (id:1)

[brucedawson, 2016-12-09 18:30:23]

lgtm - I'll investigate the regression.

[commit-bot: I haz the power, 2016-12-12 14:35:42]

Description was changed from

==========
Revert of Change ExecLinkWrapper to not buffer all tool output (patchset #2
id:20001 of https://codereview.chromium.org/2558153002/ )

Reason for revert:
Reverting under suspicion for crbug.com/672841.

Original issue's description:
> Change ExecLinkWrapper to not buffer all tool output
> 
> /verbose linking of chrome.dll creates over one GB of output. This
> causes ExecLinkWrapper to consume over two GB of memory which leads to
> an OOM failure in the 32-bit depot_tools python, and the loss of all
> of the valuable output. This change modifies ExecLinkWrapper to
> process the output one line at a time, thus avoiding the OOM.
> 
> I've tested that this handles the 1.1 GB of output which the previous
> version of this function failed on and I've visually confirmed that the
> output looks the same - no extraneous blank lines, for instance, when
> displaying warnings, errors, or 1.9 million lines of verbose output.
> 
> I also verified that the script stays idle when waiting for output -
> blocking on .readline().
> 
> BUG=672182
> 
> Committed: https://crrev.com/5d0d1b0bf01acb3ebe3a5ef27ebf2f3180ab1d1d
> Cr-Commit-Position: refs/heads/master@{#437126}

TBR=brucedawson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=672182

Review-Url: https://codereview.chromium.org/2564893002
==========

to

==========
Revert of Change ExecLinkWrapper to not buffer all tool output (patchset #2
id:20001 of https://codereview.chromium.org/2558153002/ )

Reason for revert:
Reverting under suspicion for crbug.com/672841.

Original issue's description:
> Change ExecLinkWrapper to not buffer all tool output
>
> /verbose linking of chrome.dll creates over one GB of output. This
> causes ExecLinkWrapper to consume over two GB of memory which leads to
> an OOM failure in the 32-bit depot_tools python, and the loss of all
> of the valuable output. This change modifies ExecLinkWrapper to
> process the output one line at a time, thus avoiding the OOM.
>
> I've tested that this handles the 1.1 GB of output which the previous
> version of this function failed on and I've visually confirmed that the
> output looks the same - no extraneous blank lines, for instance, when
> displaying warnings, errors, or 1.9 million lines of verbose output.
>
> I also verified that the script stays idle when waiting for output -
> blocking on .readline().
>
> BUG=672182
>
> Committed: https://crrev.com/5d0d1b0bf01acb3ebe3a5ef27ebf2f3180ab1d1d
> Cr-Commit-Position: refs/heads/master@{#437126}

TBR=brucedawson@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=672182

Committed: https://crrev.com/8e0b754f6372a0d5fc6d1c1df1597dfb9ac877ed
Cr-Commit-Position: refs/heads/master@{#437572}
==========

[commit-bot: I haz the power, 2016-12-12 14:35:43]

Patchset 1 (id:??) landed as
https://crrev.com/8e0b754f6372a0d5fc6d1c1df1597dfb9ac877ed
Cr-Commit-Position: refs/heads/master@{#437572}