Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 256483004: Remove serialization version tags from crypto LayoutTests. (Closed)

Created:
6 years, 8 months ago by pwnall-personal
Modified:
6 years, 8 months ago
Reviewers:
eroman
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove serialization version tags from crypto LayoutTests. The LayoutTests in crypto/ are the only tests that dump objects' complete serialization. This has the unfortunate side effect that any change to the serialization format must update the -expected.txt files in the crypto/ tests (due to the version number bump). The changes currently add 224 lines to a diff, and cause unnecessary churn in the crypto/ tests. This change removes the version tag (first two bytes) from the dumped output, removing the churn source discussed above. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+230 lines, -226 lines) Patch
M LayoutTests/crypto/clone-aesKey-expected.txt View 48 chunks +48 lines, -48 lines 0 comments Download
M LayoutTests/crypto/clone-hmacKey-expected.txt View 48 chunks +48 lines, -48 lines 0 comments Download
M LayoutTests/crypto/clone-rsaHashedKey-private-expected.txt View 48 chunks +48 lines, -48 lines 0 comments Download
M LayoutTests/crypto/clone-rsaHashedKey-public-expected.txt View 48 chunks +48 lines, -48 lines 0 comments Download
M LayoutTests/crypto/clone-rsaKey-private-expected.txt View 16 chunks +16 lines, -16 lines 0 comments Download
M LayoutTests/crypto/clone-rsaKey-public-expected.txt View 16 chunks +16 lines, -16 lines 0 comments Download
M LayoutTests/crypto/resources/common.js View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pwnall-personal
Can you please take a look? I put this together because the -expected.txt changes more ...
6 years, 8 months ago (2014-04-24 16:32:44 UTC) #1
eroman
LGTM! Sorry for the inconvenience.
6 years, 8 months ago (2014-04-24 18:55:00 UTC) #2
eroman
The CQ bit was checked by eroman@chromium.org
6 years, 8 months ago (2014-04-24 18:55:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/costan@gmail.com/256483004/1
6 years, 8 months ago (2014-04-24 18:55:44 UTC) #4
pwnall-personal
On 2014/04/24 18:55:00, eroman wrote: > LGTM! > > Sorry for the inconvenience. Absolutely not ...
6 years, 8 months ago (2014-04-24 19:12:40 UTC) #5
commit-bot: I haz the power
6 years, 8 months ago (2014-04-24 23:26:22 UTC) #6
Message was sent while issue was closed.
Change committed as 172555

Powered by Google App Engine
This is Rietveld 408576698