Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issue 256483003: Add DEFINE_STATIC_REF_WILL_BE_PERSISTENT macro (Closed)

Created:
6 years, 8 months ago by keishi
Modified:
6 years, 7 months ago
Reviewers:
haraken, oilpan-reviews, sof
CC:
blink-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Visibility:
Public.

Description

Add DEFINE_STATIC_REF_WILL_BE_PERSISTENT macro BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173169

Patch Set 1 #

Patch Set 2 : Used macro #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M Source/core/animation/AnimatableStrokeDasharrayList.cpp View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/animation/AnimatableValue.cpp View 1 2 1 chunk +1 line, -6 lines 0 comments Download
M Source/platform/heap/Handle.h View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
keishi
Separated out from https://codereview.chromium.org/205173002/
6 years, 8 months ago (2014-04-24 03:44:36 UTC) #1
keishi
6 years, 8 months ago (2014-04-24 03:44:56 UTC) #2
haraken
LGTM. I would be great if you could remove existing #if ENABLE(OILPAN)'s from the code ...
6 years, 8 months ago (2014-04-24 03:52:16 UTC) #3
keishi
On 2014/04/24 03:52:16, haraken wrote: > LGTM. I would be great if you could remove ...
6 years, 8 months ago (2014-04-24 05:21:36 UTC) #4
haraken
Thanks, LGTM.
6 years, 8 months ago (2014-04-24 05:22:53 UTC) #5
sof
A corresponding one for DEFINE_STATIC_LOCAL might be worth adding by the next one that needs ...
6 years, 8 months ago (2014-04-24 05:31:23 UTC) #6
haraken
On 2014/04/24 05:31:23, sof wrote: > A corresponding one for DEFINE_STATIC_LOCAL might be worth adding ...
6 years, 8 months ago (2014-04-24 06:20:56 UTC) #7
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 8 months ago (2014-04-24 06:48:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/256483003/30001
6 years, 8 months ago (2014-04-24 06:49:12 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 07:21:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_rel
6 years, 8 months ago (2014-04-24 07:21:26 UTC) #11
keishi
The CQ bit was checked by keishi@chromium.org
6 years, 7 months ago (2014-05-02 03:41:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/256483003/30001
6 years, 7 months ago (2014-05-02 03:41:39 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 04:13:48 UTC) #14
Message was sent while issue was closed.
Change committed as 173169

Powered by Google App Engine
This is Rietveld 408576698