Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issue 2564773003: Increase load of blink_perf.paint to reduce flakiness (Closed)

Created:
4 years ago by Xianzhu
Modified:
4 years ago
Reviewers:
chrishtr, pdr.
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Increase load of blink_perf.paint to reduce flakiness We measure frame time so the granularity of frame cycle affects the accuracy (small load sometime causes 1 cycle flakiness) and visibility (performance difference of a too small load is hidden by the smallest frame cycle) of the results. See https://goo.gl/wGEsdM for samples of the flakiness. Increase load to avoid the above issues, especially after we excluded GC time from the measured time (https://codereview.chromium.org/2559893002/) for crbug.com/667811. Now most of the measured times on my local Linux machine are between 100ms and 300ms. Modified some tests to avoid the increased load from causing too much layout time. NOTRY=true (try bots help nothing for this CL) Committed: https://crrev.com/2ad505df6c7974c38b2130c71169e60b679bbae2 Cr-Commit-Position: refs/heads/master@{#437652}

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : Fix a typo #

Messages

Total messages: 23 (14 generated)
Xianzhu
4 years ago (2016-12-09 18:30:58 UTC) #4
chrishtr
lgtm
4 years ago (2016-12-09 18:35:08 UTC) #8
pdr.
We need to watch out for some of those buildTree calls, since they create on ...
4 years ago (2016-12-09 19:12:57 UTC) #9
Xianzhu
On 2016/12/09 19:12:57, pdr. wrote: > We need to watch out for some of those ...
4 years ago (2016-12-09 19:16:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564773003/40001
4 years ago (2016-12-09 19:17:35 UTC) #13
pdr.
On 2016/12/09 at 19:16:46, wangxianzhu wrote: > On 2016/12/09 19:12:57, pdr. wrote: > > We ...
4 years ago (2016-12-09 19:17:57 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564773003/40001
4 years ago (2016-12-09 20:20:51 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-09 21:08:25 UTC) #21
commit-bot: I haz the power
4 years ago (2016-12-12 14:40:50 UTC) #23
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2ad505df6c7974c38b2130c71169e60b679bbae2
Cr-Commit-Position: refs/heads/master@{#437652}

Powered by Google App Engine
This is Rietveld 408576698