Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 2564773002: Enable page_cycler_v2 and loading.mobile on webview (Closed)

Created:
4 years ago by Kunihiko Sakamoto
Modified:
4 years ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, telemetry-reviews_chromium.org, nednguyen
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable page_cycler_v2 and loading.mobile on webview https://crrev.com/2558743002 fixed a bug that loading metric doesn't work for webview traces. This patch re-enables page_cycler_v2 and loading.mobile benchmarks on webview bots. BUG=651188 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Committed: https://crrev.com/17ed06fc0eb8ea831568682a4ed2be93ce329a44 Cr-Commit-Position: refs/heads/master@{#437822}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M tools/perf/benchmarks/loading.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/benchmarks/page_cycler_v2.py View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Kunihiko Sakamoto
4 years ago (2016-12-09 06:49:03 UTC) #4
kouhei (in TOK)
lgtm
4 years ago (2016-12-09 06:51:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564773002/1
4 years ago (2016-12-09 06:52:16 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/195778)
4 years ago (2016-12-09 08:28:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564773002/1
4 years ago (2016-12-12 01:08:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 05:38:00 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-12 15:10:40 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/17ed06fc0eb8ea831568682a4ed2be93ce329a44
Cr-Commit-Position: refs/heads/master@{#437822}

Powered by Google App Engine
This is Rietveld 408576698