third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp - Issue 2564633002: Don't create layout objects for children of display-none iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

Issue 2564633002: Don't create layout objects for children of display-none iframes. (Closed)

Patch Set: Comments from esprehn. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp b/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

index c3d7eef11ca1e6626ed3c0c89ee9a7d33aaaf96d..492a42066f45b6754c3d93005f7a41e1ab03c32a 100644

--- a/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

+++ b/third_party/WebKit/Source/core/layout/VisualRectMappingTest.cpp

@@ -220,9 +220,8 @@ TEST_F(VisualRectMappingTest, LayoutViewDisplayNone) {

frameElement->setInlineStyleProperty(CSSPropertyDisplay, "none");

document().view()->updateAllLifecyclePhases();

- rect = originalRect;

- EXPECT_FALSE(frameDiv->mapToVisualRectInAncestorSpace(&layoutView(), rect));

- EXPECT_EQ(rect, LayoutRect());

+ frameBody = toLayoutBlock(childDocument().body()->layoutObject());

+ EXPECT_EQ(nullptr, frameBody);

}

TEST_F(VisualRectMappingTest, SelfFlippedWritingMode) {