third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-block-to-display-none.html - Issue 2564633002: Don't create layout objects for children of display-none iframes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-block-to-display-none.html

Issue 2564633002: Don't create layout objects for children of display-none iframes. (Closed)

Patch Set: Comments from esprehn. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/frame_owner_properties.cc ('k') | third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-none-to-display-block.html » ('j') | third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-none-to-display-block.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-block-to-display-none.html

diff --git a/third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-block-to-display-none.html b/third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-block-to-display-none.html

new file mode 100644

index 0000000000000000000000000000000000000000..b4feaf52215d23bda24fa450e4c8d3e333081b4f

--- /dev/null

+++ b/third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-block-to-display-none.html

@@ -0,0 +1,19 @@

+<!DOCTYPE html>

+<html>

esprehn 2016/12/16 21:29:44 I'd leave out html and body, the test doesn't need

erikchen 2016/12/16 22:42:10 Done.

+<script src="resources/text-based-repaint.js" type="text/javascript"></script>

esprehn 2016/12/16 21:29:44 no type attr

erikchen 2016/12/16 22:42:10 Done.

+<script>

+function repaintTest()

+ iframe.style.display = "none";

esprehn 2016/12/16 21:29:44 document.getElementById("iframe") avoids the magic

erikchen 2016/12/16 22:42:10 Done.

+window.addEventListener("load", runRepaintAndPixelTest, false);

esprehn 2016/12/16 21:29:44 no false

erikchen 2016/12/16 22:42:10 Done.

+</script>

+<body>

+ <p><a href="https://code.google.com/p/chromium/issues/detail?id=650433">issue 650433</a>:

+ display:none iframes do not have layout objects<br>

+ The test checks that changing the style of an iframe from block to none

+ creates the right sequence of paint invalidations.

+ </p>

+ <iframe id="iframe" width="728" height="90" style="display: block"></iframe>

+</body>

+</html>