third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-block-to-display-none.html - Issue 2564633002: Don't create layout objects for children of display-none iframes.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-block-to-display-none.html

Issue 2564633002: Don't create layout objects for children of display-none iframes. (Closed)

Patch Set: Comments from esprehn. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « content/common/frame_owner_properties.cc ('k') | third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-none-to-display-block.html » ('j') | third_party/WebKit/LayoutTests/paint/invalidation/iframe-display-none-to-display-block.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>
	esprehn 2016/12/16 21:29:44 I'd leave out html and body, the test doesn't need I'd leave out html and body, the test doesn't need it. erikchen 2016/12/16 22:42:10 Done. Show quoted text On 2016/12/16 21:29:44, esprehn wrote: > I'd leave out html and body, the test doesn't need it. Done.
	3 <script src="resources/text-based-repaint.js" type="text/javascript"></script>
	esprehn 2016/12/16 21:29:44 no type attr no type attr erikchen 2016/12/16 22:42:10 Done. Show quoted text On 2016/12/16 21:29:44, esprehn wrote: > no type attr Done.
	4 <script>

	5 function repaintTest()

	6 {

	7 iframe.style.display = "none";
	esprehn 2016/12/16 21:29:44 document.getElementById("iframe") avoids the magic document.getElementById("iframe") avoids the magic that makes this lookup by id work. erikchen 2016/12/16 22:42:10 Done. Show quoted text On 2016/12/16 21:29:44, esprehn wrote: > document.getElementById("iframe") avoids the magic that makes this lookup by id > work. Done.
	8 }

	9 window.addEventListener("load", runRepaintAndPixelTest, false);
	esprehn 2016/12/16 21:29:44 no false no false erikchen 2016/12/16 22:42:10 Done. Show quoted text On 2016/12/16 21:29:44, esprehn wrote: > no false Done.
	10 </script>

	11 <body>

	12 <p><a href="https://code.google.com/p/chromium/issues/detail?id=650433">issu e 650433</a>:

	13 display:none iframes do not have layout objects<br>

	14 The test checks that changing the style of an iframe from block to none

	15 creates the right sequence of paint invalidations.

	16 </p>

	17 <iframe id="iframe" width="728" height="90" style="display: block"></iframe>

	18 </body>

	19 </html>

OLD	NEW