Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 2564633002: Don't create layout objects for children of display-none iframes. (Closed)
Patch Set: Add new layout tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
index 1fae82c8c4a3e6370dcdf609113356638529306a..91c815e74925e2869e1520f2c856957f16b4fc02 100644
--- a/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
+++ b/third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp
@@ -889,7 +889,7 @@ void FrameLoaderClientImpl::didAddContentSecurityPolicy(
}
void FrameLoaderClientImpl::didChangeFrameOwnerProperties(
- HTMLFrameElementBase* frameElement) {
+ HTMLFrameOwnerElement* frameElement) {
if (!m_webFrame->client())
return;
@@ -898,7 +898,8 @@ void FrameLoaderClientImpl::didChangeFrameOwnerProperties(
WebFrameOwnerProperties(
frameElement->scrollingMode(), frameElement->marginWidth(),
frameElement->marginHeight(), frameElement->allowFullscreen(),
- frameElement->csp(), frameElement->delegatedPermissions()));
+ frameElement->isDisplayNone(), frameElement->csp(),
+ frameElement->delegatedPermissions()));
}
void FrameLoaderClientImpl::dispatchWillStartUsingPeerConnectionHandler(

Powered by Google App Engine
This is Rietveld 408576698