Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: third_party/WebKit/Source/web/FrameLoaderClientImpl.cpp

Issue 2564633002: Don't create layout objects for children of display-none iframes. (Closed)
Patch Set: Add new layout tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
3 * Copyright (C) 2011 Apple Inc. All rights reserved. 3 * Copyright (C) 2011 Apple Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 871 matching lines...) Expand 10 before | Expand all | Expand 10 after
882 ContentSecurityPolicyHeaderType type, 882 ContentSecurityPolicyHeaderType type,
883 ContentSecurityPolicyHeaderSource source) { 883 ContentSecurityPolicyHeaderSource source) {
884 if (m_webFrame->client()) { 884 if (m_webFrame->client()) {
885 m_webFrame->client()->didAddContentSecurityPolicy( 885 m_webFrame->client()->didAddContentSecurityPolicy(
886 headerValue, static_cast<WebContentSecurityPolicyType>(type), 886 headerValue, static_cast<WebContentSecurityPolicyType>(type),
887 static_cast<WebContentSecurityPolicySource>(source)); 887 static_cast<WebContentSecurityPolicySource>(source));
888 } 888 }
889 } 889 }
890 890
891 void FrameLoaderClientImpl::didChangeFrameOwnerProperties( 891 void FrameLoaderClientImpl::didChangeFrameOwnerProperties(
892 HTMLFrameElementBase* frameElement) { 892 HTMLFrameOwnerElement* frameElement) {
893 if (!m_webFrame->client()) 893 if (!m_webFrame->client())
894 return; 894 return;
895 895
896 m_webFrame->client()->didChangeFrameOwnerProperties( 896 m_webFrame->client()->didChangeFrameOwnerProperties(
897 WebFrame::fromFrame(frameElement->contentFrame()), 897 WebFrame::fromFrame(frameElement->contentFrame()),
898 WebFrameOwnerProperties( 898 WebFrameOwnerProperties(
899 frameElement->scrollingMode(), frameElement->marginWidth(), 899 frameElement->scrollingMode(), frameElement->marginWidth(),
900 frameElement->marginHeight(), frameElement->allowFullscreen(), 900 frameElement->marginHeight(), frameElement->allowFullscreen(),
901 frameElement->csp(), frameElement->delegatedPermissions())); 901 frameElement->isDisplayNone(), frameElement->csp(),
902 frameElement->delegatedPermissions()));
902 } 903 }
903 904
904 void FrameLoaderClientImpl::dispatchWillStartUsingPeerConnectionHandler( 905 void FrameLoaderClientImpl::dispatchWillStartUsingPeerConnectionHandler(
905 WebRTCPeerConnectionHandler* handler) { 906 WebRTCPeerConnectionHandler* handler) {
906 m_webFrame->client()->willStartUsingPeerConnectionHandler(handler); 907 m_webFrame->client()->willStartUsingPeerConnectionHandler(handler);
907 } 908 }
908 909
909 bool FrameLoaderClientImpl::allowWebGL(bool enabledPerSettings) { 910 bool FrameLoaderClientImpl::allowWebGL(bool enabledPerSettings) {
910 if (m_webFrame->client()) 911 if (m_webFrame->client())
911 return m_webFrame->client()->allowWebGL(enabledPerSettings); 912 return m_webFrame->client()->allowWebGL(enabledPerSettings);
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
995 WebDevToolsAgentImpl* FrameLoaderClientImpl::devToolsAgent() { 996 WebDevToolsAgentImpl* FrameLoaderClientImpl::devToolsAgent() {
996 return WebLocalFrameImpl::fromFrame(m_webFrame->frame()->localFrameRoot()) 997 return WebLocalFrameImpl::fromFrame(m_webFrame->frame()->localFrameRoot())
997 ->devToolsAgentImpl(); 998 ->devToolsAgentImpl();
998 } 999 }
999 1000
1000 KURL FrameLoaderClientImpl::overrideFlashEmbedWithHTML(const KURL& url) { 1001 KURL FrameLoaderClientImpl::overrideFlashEmbedWithHTML(const KURL& url) {
1001 return m_webFrame->client()->overrideFlashEmbedWithHTML(WebURL(url)); 1002 return m_webFrame->client()->overrideFlashEmbedWithHTML(WebURL(url));
1002 } 1003 }
1003 1004
1004 } // namespace blink 1005 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698