memory coordinator: Throttle background renderers on Android

memory coordinator: Throttle background renderers on Android

On mobile devices, there are less available memory and high tab
switching cost compared to desktop environments. Given that, it would
make sense to throttle background renderers immediately.

BUG=617492
Committed: https://crrev.com/feae988cc92320f9f7d8f0d9a5fa5056d11e3f69
Cr-Commit-Position: refs/heads/master@{#437476}

[bashi, 2016-12-09 03:03:48]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 03:04:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2016-12-09 03:11:16]

bashi@chromium.org changed reviewers:
+ chrisha@chromium.org, haraken@chromium.org

[bashi, 2016-12-09 03:11:16]

PTAL

It would be better to avoid ifdefs (instead adding MemoryCoordinatorAndroid) but
it may be a bit overkill.

https://codereview.chromium.org/2564623004/diff/1/content/browser/memory/memo...
File content/browser/memory/memory_coordinator_unittest.cc (right):

https://codereview.chromium.org/2564623004/diff/1/content/browser/memory/memo...
content/browser/memory/memory_coordinator_unittest.cc:29: :
state_(mojom::MemoryState::NORMAL),
I had to change the initial state to NORMAL because MemoryCoordinator::ChildInfo
is initialized with NORMAL state. SetChildMemoryState() won't call
OnStateChange() when a given state and the current state are the same. It means
that the first call of SetChildMemoryState(NORMAL) doesn't change |state_| and
it remains UNKNOWN, resulted in unexpected behavior.

[haraken, 2016-12-09 03:48:50]

LGTM

https://codereview.chromium.org/2564623004/diff/1/content/browser/memory/memo...
File content/browser/memory/memory_coordinator.cc (right):

https://codereview.chromium.org/2564623004/diff/1/content/browser/memory/memo...
content/browser/memory/memory_coordinator.cc:91: memory_state =
OverrideChildState(memory_state, iter->second);

OverrideGlobalState ?

I might want to unify terms into "global states" and "local states".

[bashi, 2016-12-09 04:18:46]

https://codereview.chromium.org/2564623004/diff/1/content/browser/memory/memo...
File content/browser/memory/memory_coordinator.cc (right):

https://codereview.chromium.org/2564623004/diff/1/content/browser/memory/memo...
content/browser/memory/memory_coordinator.cc:91: memory_state =
OverrideChildState(memory_state, iter->second);
On 2016/12/09 03:48:50, haraken wrote:
> 
> OverrideGlobalState ?
Done. Maybe "Override" isn't a good verb for this method. There will be better
name for this method but I couldn't come up with better names.
> 
> I might want to unify terms into "global states" and "local states".

We can replace "the current state" with "local state" but we still need to say
"child states".

[bashi, 2016-12-09 04:19:07]

The CQ bit was checked by bashi@chromium.org

[bashi, 2016-12-09 04:19:07]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2564623004/#ps20001
(title: "naming")

[commit-bot: I haz the power, 2016-12-09 04:19:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 05:23:23]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481257147061700,
"parent_rev": "aa322dbb203ef413f8253b8193734472979ab079", "commit_rev":
"0f0ec69694109b49e8f5b7c83d3453e4354c4177"}

[commit-bot: I haz the power, 2016-12-09 05:24:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-09 05:26:37]

Description was changed from

==========
memory coordinator: Throttle background renderers on Android

On mobile devices, there are less available memory and high tab
switching cost compared to desktop environments. Given that, it would
make sense to throttle background renderers immediately.

BUG=617492
==========

to

==========
memory coordinator: Throttle background renderers on Android

On mobile devices, there are less available memory and high tab
switching cost compared to desktop environments. Given that, it would
make sense to throttle background renderers immediately.

BUG=617492

Committed: https://crrev.com/feae988cc92320f9f7d8f0d9a5fa5056d11e3f69
Cr-Commit-Position: refs/heads/master@{#437476}
==========

[commit-bot: I haz the power, 2016-12-09 05:26:38]

Patchset 2 (id:??) landed as
https://crrev.com/feae988cc92320f9f7d8f0d9a5fa5056d11e3f69
Cr-Commit-Position: refs/heads/master@{#437476}