Issue 25646004: Add Dart_PostPriority function to dart_api, and use it in runAsync to schedule immediate events in …

Issue 25646004: Add Dart_PostPriority function to dart_api, and use it in runAsync to schedule immediate events in … (Closed)

Created:
7 years, 2 months ago by Anders Johnsen

Modified:
7 years ago

Reviewers:
Lasse Reichstein Nielsen, floitsch, Søren Gjesse, siva, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add Dart_PostPriority function to dart_api, and use it in runAsync to schedule immediate events in the VM. BUG= https://dartbug.com/9001

Patch Set 3 : More cleanup #

Total comments: 3

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+92 lines, -11 lines)			Patch
M	runtime/bin/builtin_natives.cc	View		2 chunks	+10 lines, -0 lines	0 comments	Download
M	runtime/bin/common_patch.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/bin/dartutils.cc	View		2 chunks	+10 lines, -1 line	0 comments	Download
M	runtime/include/dart_api.h	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/lib/event_loop_patch.dart	View		1 chunk	+16 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View		1 chunk	+13 lines, -0 lines	0 comments	Download
M	runtime/vm/message.h	View	1	1 chunk	+2 lines, -5 lines	3 comments	Download
M	runtime/vm/message.cc	View	1	1 chunk	+9 lines, -3 lines	0 comments	Download
M	sdk/lib/io/common.dart	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

This introduces the concept of a 'kFirstPriority' for Messages. Note that multiple PostPriority calls would ...

7 years, 2 months ago (2013-10-03 08:36:37 UTC) #1

Lasse Reichstein Nielsen

LGTM, but do wait for VM'er acceptance. https://codereview.chromium.org/25646004/diff/3001/runtime/vm/message.h File runtime/vm/message.h (right): https://codereview.chromium.org/25646004/diff/3001/runtime/vm/message.h#newcode19 runtime/vm/message.h:19: kFirstPriority = ...

7 years, 2 months ago (2013-10-03 08:53:41 UTC) #2

floitsch

7 years, 2 months ago (2013-10-03 09:04:26 UTC) #3

Dart and some C++ code LGTM, but wait for VM devs to have a look at the C++
code.

https://codereview.chromium.org/25646004/diff/3001/runtime/vm/message.h
File runtime/vm/message.h (right):

https://codereview.chromium.org/25646004/diff/3001/runtime/vm/message.h#newco...
runtime/vm/message.h:19: kFirstPriority = 1,   // Deliver message asap.
On 2013/10/03 08:53:41, Lasse Reichstein Nielsen wrote:
> asap->ASAP.

Maybe just: Deliver message when idle before normal priority.

Expand Messages | Collapse Messages