ChromeOS MD-OOBE: Add Timezone Selection screen.

ChromeOS MD-OOBE: Add Timezone Selection screen.

This CL implements Timezone Selection screen for material design ChromeOS OOBE.

BUG=604119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/aaa7336c821888839f759c6c0a36b56c6678bbc0
Cr-Commit-Position: refs/heads/master@{#437745}

[Alexander Alekseev, 2016-12-09 11:52:56]

Description was changed from

==========
ChromeOS MD-OOBE: Add Timezone Selection screen.

This CL implements Timezone Selection screen for material design ChromeOS OOBE.

BUG=604119
==========

to

==========
ChromeOS MD-OOBE: Add Timezone Selection screen.

This CL implements Timezone Selection screen for material design ChromeOS OOBE.

BUG=604119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Alexander Alekseev, 2016-12-09 11:54:27]

alemate@chromium.org changed reviewers:
+ xiyuan@chromium.org

[Alexander Alekseev, 2016-12-09 11:54:28]

Please review.

[Alexander Alekseev, 2016-12-09 11:54:33]

The CQ bit was checked by alemate@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 11:54:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 13:06:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 13:06:56]

Dry run: This issue passed the CQ dry run.

[xiyuan, 2016-12-09 17:50:59]

lgtm

https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_welcome.css (right):

https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome.css:57: font: 13px Roboto,
sans-serif;
nit: Can we just specify font-size? Think the fonts listed here are the defaults
in the login screen webui.

i.e.
  font-size: 13px;

https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_welcome.js (right):

https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome.js:185: return false;
nit: think we can do

  return highlightStrength === 'strong';

https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome.js:422: var timezone =
item.value;
nit: get rid of |timezone| and use item.value in place

[Alexander Alekseev, 2016-12-10 00:43:00]

https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_welcome.css (right):

https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome.css:57: font: 13px Roboto,
sans-serif;
On 2016/12/09 17:50:59, xiyuan wrote:
> nit: Can we just specify font-size? Think the fonts listed here are the
defaults
> in the login screen webui.
> 
> i.e.
>   font-size: 13px;

This is a tricky question as MD-OOBE is technically a part of old OOBE, which
has different fonts. So I'd leave this as it is.

https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/ch...
File chrome/browser/resources/chromeos/login/oobe_welcome.js (right):

https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome.js:185: return false;
On 2016/12/09 17:50:59, xiyuan wrote:
> nit: think we can do
> 
>   return highlightStrength === 'strong';

Done.

https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/ch...
chrome/browser/resources/chromeos/login/oobe_welcome.js:422: var timezone =
item.value;
On 2016/12/09 17:50:59, xiyuan wrote:
> nit: get rid of |timezone| and use item.value in place

Done.

[Alexander Alekseev, 2016-12-10 00:43:05]

The CQ bit was checked by alemate@chromium.org

[Alexander Alekseev, 2016-12-10 00:43:05]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/2564563004/#ps20001
(title: "Update after review.")

[commit-bot: I haz the power, 2016-12-10 00:43:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 04:00:46]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481330585050750,
"parent_rev": "b90127f9c3bf843704336ded8868ed6cd7addae2", "commit_rev":
"4f62d75bb7fbdd9a9bc0cb0bc40c650cffd77993"}

[commit-bot: I haz the power, 2016-12-10 04:01:14]

Description was changed from

==========
ChromeOS MD-OOBE: Add Timezone Selection screen.

This CL implements Timezone Selection screen for material design ChromeOS OOBE.

BUG=604119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
ChromeOS MD-OOBE: Add Timezone Selection screen.

This CL implements Timezone Selection screen for material design ChromeOS OOBE.

BUG=604119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2564563004
==========

[commit-bot: I haz the power, 2016-12-10 04:01:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-12 15:06:09]

Description was changed from

==========
ChromeOS MD-OOBE: Add Timezone Selection screen.

This CL implements Timezone Selection screen for material design ChromeOS OOBE.

BUG=604119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2564563004
==========

to

==========
ChromeOS MD-OOBE: Add Timezone Selection screen.

This CL implements Timezone Selection screen for material design ChromeOS OOBE.

BUG=604119
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/aaa7336c821888839f759c6c0a36b56c6678bbc0
Cr-Commit-Position: refs/heads/master@{#437745}
==========

[commit-bot: I haz the power, 2016-12-12 15:06:11]

Patchset 2 (id:??) landed as
https://crrev.com/aaa7336c821888839f759c6c0a36b56c6678bbc0
Cr-Commit-Position: refs/heads/master@{#437745}