Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 2564563004: ChromeOS MD-OOBE: Add Timezone Selection screen. (Closed)

Created:
4 years ago by Alexander Alekseev
Modified:
4 years ago
Reviewers:
xiyuan
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS MD-OOBE: Add Timezone Selection screen. This CL implements Timezone Selection screen for material design ChromeOS OOBE. BUG=604119 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/aaa7336c821888839f759c6c0a36b56c6678bbc0 Cr-Commit-Position: refs/heads/master@{#437745}

Patch Set 1 #

Total comments: 6

Patch Set 2 : Update after review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -2 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_network.js View 2 chunks +12 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_types.js View 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.css View 1 chunk +21 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.html View 3 chunks +38 lines, -1 line 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome.js View 1 6 chunks +70 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome_dialog.js View 2 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Alexander Alekseev
Please review.
4 years ago (2016-12-09 11:54:28 UTC) #3
xiyuan
lgtm https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/chromeos/login/oobe_welcome.css File chrome/browser/resources/chromeos/login/oobe_welcome.css (right): https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/chromeos/login/oobe_welcome.css#newcode57 chrome/browser/resources/chromeos/login/oobe_welcome.css:57: font: 13px Roboto, sans-serif; nit: Can we just ...
4 years ago (2016-12-09 17:50:59 UTC) #8
Alexander Alekseev
https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/chromeos/login/oobe_welcome.css File chrome/browser/resources/chromeos/login/oobe_welcome.css (right): https://codereview.chromium.org/2564563004/diff/1/chrome/browser/resources/chromeos/login/oobe_welcome.css#newcode57 chrome/browser/resources/chromeos/login/oobe_welcome.css:57: font: 13px Roboto, sans-serif; On 2016/12/09 17:50:59, xiyuan wrote: ...
4 years ago (2016-12-10 00:43:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564563004/20001
4 years ago (2016-12-10 00:43:58 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-10 04:01:14 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-12 15:06:11 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aaa7336c821888839f759c6c0a36b56c6678bbc0
Cr-Commit-Position: refs/heads/master@{#437745}

Powered by Google App Engine
This is Rietveld 408576698