Quick View: Add device setting metadata.

Quick View: Add device setting metadata.

Added device setting metadata including F number, exposure time, focal length and ISO,
in the same form as the one in Google Photos.

BUG=636191
TEST=manually.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/33e0696659c759ed73c5567aa827835751d5ebd7
Cr-Commit-Position: refs/heads/master@{#438453}

[oka, 2016-12-08 12:23:15]

Description was changed from

==========
Quick View: Add lens metadata.

Added lens metadata including F number, exposure time, focal length and ISO,
in the same form as the one in Google Photos.

BUG=636191
TEST=manually.
==========

to

==========
Quick View: Add lens metadata.

Added lens metadata including F number, exposure time, focal length and ISO,
in the same form as the one in Google Photos.

BUG=636191
TEST=manually.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-12-08 12:27:57]

The CQ bit was checked by oka@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-08 12:28:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2016-12-08 12:28:36]

oka@chromium.org changed reviewers:
+ fukino@chromium.org

[oka, 2016-12-08 12:28:36]

PTAL.

[commit-bot: I haz the power, 2016-12-08 12:55:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 12:55:45]

Dry run: This issue passed the CQ dry run.

[oka, 2016-12-09 04:48:16]

PTAL.

[oka, 2016-12-09 06:07:59]

Description was changed from

==========
Quick View: Add lens metadata.

Added lens metadata including F number, exposure time, focal length and ISO,
in the same form as the one in Google Photos.

BUG=636191
TEST=manually.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Quick View: Add shooting info metadata.

Added shooting info metadata including F number, exposure time, focal length and
ISO,
in the same form as the one in Google Photos.

BUG=636191
TEST=manually.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2016-12-09 06:38:04]

lgtm with nits.

https://codereview.chromium.org/2564553002/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/elements/files_metadata_box.js
(right):

https://codereview.chromium.org/2564553002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_metadata_box.js:170: *
and the denominator.
nit: 4 space indent.

https://codereview.chromium.org/2564553002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_metadata_box.js:174:
parseRationale_: function(r) {
Rationale -> Rational

https://codereview.chromium.org/2564553002/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/elements/files_metadata_box.js:223: 'f/'
+ Number(this.parseRationale_(exif[33437].value)).toFixed(1) :
For integer F values, decimal point will not be necessary.
(I think f/22 is more common than f/22.0)
Number.isInteger should be handy here.

[oka, 2016-12-14 06:19:52]

Description was changed from

==========
Quick View: Add shooting info metadata.

Added shooting info metadata including F number, exposure time, focal length and
ISO,
in the same form as the one in Google Photos.

BUG=636191
TEST=manually.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Quick View: Add device setting metadata.

Added device setting metadata including F number, exposure time, focal length
and ISO,
in the same form as the one in Google Photos.

BUG=636191
TEST=manually.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[oka, 2016-12-14 06:22:32]

PTALA just in case. I changed shooting info to device settings according to the
discussion in the bug.

[fukino, 2016-12-14 06:33:06]

still lgtm

[oka, 2016-12-14 06:35:17]

The CQ bit was checked by oka@chromium.org

[commit-bot: I haz the power, 2016-12-14 06:35:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-14 07:27:28]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1481697317005770,
"parent_rev": "c7821dcbc19b795144bea3864d15bccc4764c809", "commit_rev":
"aaf50fdb8bf9e263ba4d9562e35d5aff7455273e"}

[commit-bot: I haz the power, 2016-12-14 07:27:55]

Description was changed from

==========
Quick View: Add device setting metadata.

Added device setting metadata including F number, exposure time, focal length
and ISO,
in the same form as the one in Google Photos.

BUG=636191
TEST=manually.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Quick View: Add device setting metadata.

Added device setting metadata including F number, exposure time, focal length
and ISO,
in the same form as the one in Google Photos.

BUG=636191
TEST=manually.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2564553002
==========

[commit-bot: I haz the power, 2016-12-14 07:27:56]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-12-14 07:29:45]

Description was changed from

==========
Quick View: Add device setting metadata.

Added device setting metadata including F number, exposure time, focal length
and ISO,
in the same form as the one in Google Photos.

BUG=636191
TEST=manually.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2564553002
==========

to

==========
Quick View: Add device setting metadata.

Added device setting metadata including F number, exposure time, focal length
and ISO,
in the same form as the one in Google Photos.

BUG=636191
TEST=manually.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/33e0696659c759ed73c5567aa827835751d5ebd7
Cr-Commit-Position: refs/heads/master@{#438453}
==========

[commit-bot: I haz the power, 2016-12-14 07:29:46]

Patchset 8 (id:??) landed as
https://crrev.com/33e0696659c759ed73c5567aa827835751d5ebd7
Cr-Commit-Position: refs/heads/master@{#438453}