Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2564503002:
Fix BlobBytesConsumer state assumption on cancellation (Closed)
|
Created:
4 years ago by yhirano Modified:
4 years ago Reviewers:
tyoshino (SeeGerritForStatus) CC:
chromium-reviews, blink-reviews, haraken Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionFix BlobBytesConsumer state assumption on cancellation
Previously BlobBytesConsumer expected no other one canceled its loader. But it
was not correct when ExecutionContext is shutting down. This CL fixes the
assumption.
BUG=666756
R=tyoshino@chromium.org
Committed: https://crrev.com/f2a0303d3178649ea9b4b822cbf04f6ab95bd500
Cr-Commit-Position: refs/heads/master@{#437540}
Patch Set 1 #Patch Set 2 : fix #Messages
Total messages: 22 (15 generated)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by yhirano@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
Description was changed from ========== Fix BlobBytesConsumer state assumption on cancellation Previously BlobBytesConsumer expected no other one canceled its loader. But it was not correct when ExecutionContext is shutting down. THis CL fixes the assumption. BUG=666756 R=tyoshino@chromium.org ========== to ========== Fix BlobBytesConsumer state assumption on cancellation Previously BlobBytesConsumer expected no other one canceled its loader. But it was not correct when ExecutionContext is shutting down. This CL fixes the assumption. BUG=666756 R=tyoshino@chromium.org ==========
lgtm
The CQ bit was checked by tyoshino@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by yhirano@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481294214138020,
"parent_rev": "52e8eadc01a218d89f572456c4cf3c8563721008", "commit_rev":
"c1b107d0735a092e6b2940c5047b62309a43ff26"}
Message was sent while issue was closed.
Description was changed from ========== Fix BlobBytesConsumer state assumption on cancellation Previously BlobBytesConsumer expected no other one canceled its loader. But it was not correct when ExecutionContext is shutting down. This CL fixes the assumption. BUG=666756 R=tyoshino@chromium.org ========== to ========== Fix BlobBytesConsumer state assumption on cancellation Previously BlobBytesConsumer expected no other one canceled its loader. But it was not correct when ExecutionContext is shutting down. This CL fixes the assumption. BUG=666756 R=tyoshino@chromium.org Review-Url: https://codereview.chromium.org/2564503002 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix BlobBytesConsumer state assumption on cancellation Previously BlobBytesConsumer expected no other one canceled its loader. But it was not correct when ExecutionContext is shutting down. This CL fixes the assumption. BUG=666756 R=tyoshino@chromium.org Review-Url: https://codereview.chromium.org/2564503002 ========== to ========== Fix BlobBytesConsumer state assumption on cancellation Previously BlobBytesConsumer expected no other one canceled its loader. But it was not correct when ExecutionContext is shutting down. This CL fixes the assumption. BUG=666756 R=tyoshino@chromium.org Committed: https://crrev.com/f2a0303d3178649ea9b4b822cbf04f6ab95bd500 Cr-Commit-Position: refs/heads/master@{#437540} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f2a0303d3178649ea9b4b822cbf04f6ab95bd500 Cr-Commit-Position: refs/heads/master@{#437540} |
