Chromium Code Reviews Chromium Code Reviews
Issue 2564493002:
Make WebSocket available again in service workers (Closed)
| Index: third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html |
| diff --git a/third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html b/third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..2d6fddbf55e067a3cff1b782d7046d266970ef6c |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html |
| @@ -0,0 +1,31 @@ |
| +<!DOCTYPE html> |
| +<title>Service Worker: WebSockets can be created in a Service Worker</title> |
| +<script src="/resources/testharness.js"></script> |
| +<script src="/resources/testharnessreport.js"></script> |
| +<script src="/resources/get-host-info.js?pipe=sub"></script> |
|
falken
2016/12/08 07:29:26
i don't think you need this
tyoshino (SeeGerritForStatus)
2016/12/08 08:55:01
Done.
|
| +<script src="../resources/test-helpers.js"></script> |
| +<script> |
| +promise_test(t => { |
| + const SCRIPT = 'resources/simple.js'; |
| + const SCOPE = 'resources/blank.html'; |
| + let registration; |
| + return service_worker_unregister_and_register(t, SCRIPT, SCOPE) |
| + .then(r => { |
| + registration = r; |
| + return wait_for_state(t, r.installing, 'activated'); |
| + }) |
| + .then(() => { |
| + return new Promise(resolve => { |
| + const channel = new MessageChannel(); |
| + channel.port1.onmessage = t.step_func(msg => { |
| + assert_equals(msg.data, 'PASS'); |
| + resolve(); |
| + }); |
| + registration.active.postMessage({port: channel.port2}, [channel.port2]); |
|
falken
2016/12/08 07:29:26
You don't need ports. Just registration.active.pos
tyoshino (SeeGerritForStatus)
2016/12/08 08:55:01
Done.
|
| + }); |
| + }) |
| + .then(() => { |
| + return service_worker_unregister(t, SCOPE); |
|
falken
2016/12/08 07:29:26
you can just call add_completion_callback(() => {
tyoshino (SeeGerritForStatus)
2016/12/08 08:55:01
Done.
|
| + }); |
| +}, 'Verify WebSockets can be created in a Service Worker'); |
|
falken
2016/12/08 07:29:26
this should be indented in service worker test sty
tyoshino (SeeGerritForStatus)
2016/12/08 08:55:01
Done.
|
| +</script> |
