third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html - Issue 2564493002: Make WebSocket available again in service workers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/websocket-in-service-worker.html

Issue 2564493002: Make WebSocket available again in service workers (Closed)

Patch Set: a Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/resources/simple.js ('K') | « third_party/WebKit/LayoutTests/http/tests/serviceworker/websocket/resources/simple.js ('k') | third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Service Worker: WebSockets can be created in a Service Worker</title>

	3 <script src="/resources/testharness.js"></script>

	4 <script src="/resources/testharnessreport.js"></script>

	5 <script src="/resources/get-host-info.js?pipe=sub"></script>
	falken 2016/12/08 07:29:26 i don't think you need this i don't think you need this tyoshino (SeeGerritForStatus) 2016/12/08 08:55:01 Done. Show quoted text On 2016/12/08 07:29:26, falken wrote: > i don't think you need this Done.
	6 <script src="../resources/test-helpers.js"></script>

	7 <script>

	8 promise_test(t => {

	9 const SCRIPT = 'resources/simple.js';

	10 const SCOPE = 'resources/blank.html';

	11 let registration;

	12 return service_worker_unregister_and_register(t, SCRIPT, SCOPE)

	13 .then(r => {

	14 registration = r;

	15 return wait_for_state(t, r.installing, 'activated');

	16 })

	17 .then(() => {

	18 return new Promise(resolve => {

	19 const channel = new MessageChannel();

	20 channel.port1.onmessage = t.step_func(msg => {

	21 assert_equals(msg.data, 'PASS');

	22 resolve();

	23 });

	24 registration.active.postMessage({port: channel.port2}, [channel.port2] );
	falken 2016/12/08 07:29:26 You don't need ports. Just registration.active.pos You don't need ports. Just registration.active.postMessage(). And inside the worker, you do event.source.postMessage(). tyoshino (SeeGerritForStatus) 2016/12/08 08:55:01 Done. Show quoted text On 2016/12/08 07:29:26, falken wrote: > You don't need ports. Just registration.active.postMessage(). And inside the > worker, you do event.source.postMessage(). Done.
	25 });

	26 })

	27 .then(() => {

	28 return service_worker_unregister(t, SCOPE);
	falken 2016/12/08 07:29:26 you can just call add_completion_callback(() => { you can just call add_completion_callback(() => { r.unregister(); }) after registration so we cleanup even if the test fails. tyoshino (SeeGerritForStatus) 2016/12/08 08:55:01 Done. Show quoted text On 2016/12/08 07:29:26, falken wrote: > you can just call add_completion_callback(() => { r.unregister(); }) after > registration so we cleanup even if the test fails. Done.
	29 });

	30 }, 'Verify WebSockets can be created in a Service Worker');
	falken 2016/12/08 07:29:26 this should be indented in service worker test sty this should be indented in service worker test style: promise_test(t => { const ....; return unregistre_and_register(...) .then(r => { registratino = r; }) .then(() => { ..... }); }, 'Verify'); tyoshino (SeeGerritForStatus) 2016/12/08 08:55:01 Done. Show quoted text On 2016/12/08 07:29:26, falken wrote: > this should be indented in service worker test style: > > promise_test(t => { > const ....; > return unregistre_and_register(...) > .then(r => { > registratino = r; > }) > .then(() => { > ..... > }); > }, 'Verify'); Done.
	31 </script>

OLD	NEW