DevTools: migrate last usages of samllIcons.png to UI.Icon

DevTools: migrate last usages of samllIcons.png to UI.Icon

This patch migrates the "left thick blue" icon, which points to the
inspected node, onto UI.Icon. As a result, the icon is now sharp
on retina!

This patch also introduces icon support for treeoutline: every
TreeElement now has TreeElement.setTrailingIcons(icons) method.
Users might call it to add icons after the treeelement's title.

In future, a symmetrical method TreeElement.setLeadingIcons(icons)
method, which will be used to migrate navigator icons over to
the UI.Icon.

BUG=669323
Committed: https://crrev.com/d5edba288a314b06675dfe87e603c9e4fcb05108
Cr-Commit-Position: refs/heads/master@{#437738}

[lushnikov, 2016-12-09 08:02:17]

Description was changed from

==========
DevTools: migrate last usages of samllIcons.png to UI.Icon

BUG=669323
==========

to

==========
DevTools: migrate last usages of samllIcons.png to UI.Icon

This patch migrates the "left thick blue" icon, which points to the inspected
node, onto UI.Icon.
As a result, the icon is now sharp on retina!

This patch also introduces icon support for treeoutline: every TreeElement now
has TreeElement.setTrailingIcons(icons) method. Users might call it to add icons
after the treeelement's title.

In future, a symmetrical method TreeElement.setLeadingIcons(icons) method, which
will be used
to migrate navigator icons over to the UI.Icon. 

BUG=669323
==========

[lushnikov, 2016-12-09 08:02:17]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org

[lushnikov, 2016-12-09 08:02:55]

Description was changed from

==========
DevTools: migrate last usages of samllIcons.png to UI.Icon

This patch migrates the "left thick blue" icon, which points to the inspected
node, onto UI.Icon.
As a result, the icon is now sharp on retina!

This patch also introduces icon support for treeoutline: every TreeElement now
has TreeElement.setTrailingIcons(icons) method. Users might call it to add icons
after the treeelement's title.

In future, a symmetrical method TreeElement.setLeadingIcons(icons) method, which
will be used
to migrate navigator icons over to the UI.Icon. 

BUG=669323
==========

to

==========
DevTools: migrate last usages of samllIcons.png to UI.Icon

This patch migrates the "left thick blue" icon, which points to the
inspected node, onto UI.Icon. As a result, the icon is now sharp
on retina!

This patch also introduces icon support for treeoutline: every
TreeElement now has TreeElement.setTrailingIcons(icons) method.
Users might call it to add icons after the treeelement's title.

In future, a symmetrical method TreeElement.setLeadingIcons(icons)
method, which will be used to migrate navigator icons over to
the UI.Icon. 

BUG=669323
==========

[lushnikov, 2016-12-09 08:03:55]

please, take a look

[lushnikov, 2016-12-09 08:04:01]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 08:04:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 09:52:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 09:52:03]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-12-09 22:04:06]

lgtm

https://codereview.chromium.org/2564433004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js (right):

https://codereview.chromium.org/2564433004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:47:
this.contentElement.addEventListener('focus', setFocused.bind(this, true));
Forgot to pass false for capture here and below.

[lushnikov, 2016-12-10 00:52:50]

https://codereview.chromium.org/2564433004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js (right):

https://codereview.chromium.org/2564433004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js:47:
this.contentElement.addEventListener('focus', setFocused.bind(this, true));
On 2016/12/09 22:04:06, dgozman wrote:
> Forgot to pass false for capture here and below.

Done.

[lushnikov, 2016-12-10 00:53:03]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-12-10 00:53:03]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2564433004/#ps60001
(title: "address comments")

[commit-bot: I haz the power, 2016-12-10 00:54:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 00:58:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 00:58:18]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[lushnikov, 2016-12-10 01:21:06]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-12-10 01:21:06]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2564433004/#ps80001
(title: "rebaseline")

[commit-bot: I haz the power, 2016-12-10 01:21:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 02:49:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 02:49:56]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[lushnikov, 2016-12-10 02:54:55]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-12-10 02:55:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 03:33:26]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481338495018810,
"parent_rev": "3d40cf244f7eb62e5819848a4efd680a427730fa", "commit_rev":
"ee81de330c8bcea707db8262a7a44843a2c79773"}

[commit-bot: I haz the power, 2016-12-10 03:33:53]

Description was changed from

==========
DevTools: migrate last usages of samllIcons.png to UI.Icon

This patch migrates the "left thick blue" icon, which points to the
inspected node, onto UI.Icon. As a result, the icon is now sharp
on retina!

This patch also introduces icon support for treeoutline: every
TreeElement now has TreeElement.setTrailingIcons(icons) method.
Users might call it to add icons after the treeelement's title.

In future, a symmetrical method TreeElement.setLeadingIcons(icons)
method, which will be used to migrate navigator icons over to
the UI.Icon. 

BUG=669323
==========

to

==========
DevTools: migrate last usages of samllIcons.png to UI.Icon

This patch migrates the "left thick blue" icon, which points to the
inspected node, onto UI.Icon. As a result, the icon is now sharp
on retina!

This patch also introduces icon support for treeoutline: every
TreeElement now has TreeElement.setTrailingIcons(icons) method.
Users might call it to add icons after the treeelement's title.

In future, a symmetrical method TreeElement.setLeadingIcons(icons)
method, which will be used to migrate navigator icons over to
the UI.Icon. 

BUG=669323

Review-Url: https://codereview.chromium.org/2564433004
==========

[commit-bot: I haz the power, 2016-12-10 03:33:54]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-12 15:05:54]

Description was changed from

==========
DevTools: migrate last usages of samllIcons.png to UI.Icon

This patch migrates the "left thick blue" icon, which points to the
inspected node, onto UI.Icon. As a result, the icon is now sharp
on retina!

This patch also introduces icon support for treeoutline: every
TreeElement now has TreeElement.setTrailingIcons(icons) method.
Users might call it to add icons after the treeelement's title.

In future, a symmetrical method TreeElement.setLeadingIcons(icons)
method, which will be used to migrate navigator icons over to
the UI.Icon. 

BUG=669323

Review-Url: https://codereview.chromium.org/2564433004
==========

to

==========
DevTools: migrate last usages of samllIcons.png to UI.Icon

This patch migrates the "left thick blue" icon, which points to the
inspected node, onto UI.Icon. As a result, the icon is now sharp
on retina!

This patch also introduces icon support for treeoutline: every
TreeElement now has TreeElement.setTrailingIcons(icons) method.
Users might call it to add icons after the treeelement's title.

In future, a symmetrical method TreeElement.setLeadingIcons(icons)
method, which will be used to migrate navigator icons over to
the UI.Icon.

BUG=669323

Committed: https://crrev.com/d5edba288a314b06675dfe87e603c9e4fcb05108
Cr-Commit-Position: refs/heads/master@{#437738}
==========

[commit-bot: I haz the power, 2016-12-12 15:05:55]

Patchset 5 (id:??) landed as
https://crrev.com/d5edba288a314b06675dfe87e603c9e4fcb05108
Cr-Commit-Position: refs/heads/master@{#437738}