Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 2564423003: [Blink>Paint] Document element cannot always omit isolation (Closed)

Created:
4 years ago by trchen
Modified:
4 years ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Blink>Paint] Document element cannot always omit isolation The previous assumption that nothing can be the backdrop of the document element's stacking context was incorrect, because document background doesn't paint as a part of the stacking context but as canvas backdrop instead. Note that only non-composited blending elements are affected by this bug. This CL changes behavior to match composited code path, which also matches Firefox behavior. BUG=673597 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/cf97fd35cae7ca6fae58cff6eea2f6cc59716171 Cr-Commit-Position: refs/heads/master@{#438298}

Patch Set 1 #

Messages

Total messages: 15 (10 generated)
trchen
4 years ago (2016-12-13 02:30:02 UTC) #4
pdr.
Traced back to https://src.chromium.org/viewvc/blink?view=rev&revision=160444, seems like it was an incomplete fix. LGTM
4 years ago (2016-12-13 04:52:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564423003/1
4 years ago (2016-12-13 21:42:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 21:54:11 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-13 21:58:16 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf97fd35cae7ca6fae58cff6eea2f6cc59716171
Cr-Commit-Position: refs/heads/master@{#438298}

Powered by Google App Engine
This is Rietveld 408576698