Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 2564403003: Revert "Roll clang 288545:289228." (Closed)

Created:
4 years ago by smut
Modified:
4 years ago
CC:
chromium-reviews, eugenis+clang_chromium.org, vmpstr+watch_chromium.org, Lei Zhang, dsinclair, yunlian, glider+clang_chromium.org, Nico, ukai+watch_chromium.org, Reid Kleckner, hans, dmikurube+clang_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Roll clang 288545:289228." This reverts commit 140c9756623a2e4357a1385726cb6d0e898addc3. Reason for revert: Breaks EarlGrey tests in Release configuration for iOS downstream. BUG=673495 NOTRY=true Committed: https://crrev.com/f65599cfb14613b9419d425edd45c18c4e5a7dd2 Cr-Commit-Position: refs/heads/master@{#438047}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/clang/scripts/update.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
smut
4 years ago (2016-12-13 03:03:42 UTC) #2
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-13 03:19:39 UTC) #4
Nico
lgtm
4 years ago (2016-12-13 03:19:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564403003/1
4 years ago (2016-12-13 03:52:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-13 03:56:51 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-13 04:00:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f65599cfb14613b9419d425edd45c18c4e5a7dd2
Cr-Commit-Position: refs/heads/master@{#438047}

Powered by Google App Engine
This is Rietveld 408576698