Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 2564353002: wayland-protocols: Add device_configuration_exists error to zcr_keyboard_configuration_v1 interface. (Closed)

Created:
4 years ago by yhanada
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

wayland-protocols: Add device_configuration_exists error to zcr_keyboard_configuration_v1 interface. This error is produced if get_keyboard_device_configuration method is called with a keyboard object that is already associated with keyboard device configuration object. BUG=670247 Committed: https://crrev.com/196cee5d79141b0edb0a8d976aafd6697b5be32e Cr-Commit-Position: refs/heads/master@{#437953}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address the comment #

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -5 lines) Patch
M third_party/wayland-protocols/include/protocol/stylus-unstable-v1-client-protocol.h View 1 2 2 chunks +12 lines, -1 line 0 comments Download
M third_party/wayland-protocols/include/protocol/stylus-unstable-v1-server-protocol.h View 1 2 2 chunks +13 lines, -1 line 0 comments Download
M third_party/wayland-protocols/protocol/stylus-protocol.c View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/wayland-protocols/unstable/stylus/stylus-unstable-v1.xml View 1 2 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
yhanada
Hi reveman@ and denniskempin@, PTAL. This change adds an error enum to keyboard_configuration_v1 interface. The ...
4 years ago (2016-12-12 06:57:11 UTC) #6
reveman
lgtm https://codereview.chromium.org/2564353002/diff/1/third_party/wayland-protocols/unstable/keyboard/keyboard-configuration-unstable-v1.xml File third_party/wayland-protocols/unstable/keyboard/keyboard-configuration-unstable-v1.xml (right): https://codereview.chromium.org/2564353002/diff/1/third_party/wayland-protocols/unstable/keyboard/keyboard-configuration-unstable-v1.xml#newcode51 third_party/wayland-protocols/unstable/keyboard/keyboard-configuration-unstable-v1.xml:51: If the given wl_keyboard object already has a ...
4 years ago (2016-12-12 11:49:31 UTC) #7
yhanada
Thanks for reviewing. https://codereview.chromium.org/2564353002/diff/1/third_party/wayland-protocols/unstable/keyboard/keyboard-configuration-unstable-v1.xml File third_party/wayland-protocols/unstable/keyboard/keyboard-configuration-unstable-v1.xml (right): https://codereview.chromium.org/2564353002/diff/1/third_party/wayland-protocols/unstable/keyboard/keyboard-configuration-unstable-v1.xml#newcode51 third_party/wayland-protocols/unstable/keyboard/keyboard-configuration-unstable-v1.xml:51: If the given wl_keyboard object already ...
4 years ago (2016-12-12 15:42:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564353002/20001
4 years ago (2016-12-12 22:33:32 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-12 23:23:01 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-12 23:26:07 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/196cee5d79141b0edb0a8d976aafd6697b5be32e
Cr-Commit-Position: refs/heads/master@{#437953}

Powered by Google App Engine
This is Rietveld 408576698