|
|
Chromium Code Reviews|
Created:
4 years ago by qyearsley Modified:
4 years ago Reviewers:
Dirk Pranke CC:
blink-reviews, chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionStop logging the start of a run for individual layout tests.
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true
BUG=673207
Committed: https://crrev.com/67aaccae4c80bb66c0a623a6e3e56b8151d6e3eb
Cr-Commit-Position: refs/heads/master@{#437924}
Patch Set 1 #Patch Set 2 : - #
Messages
Total messages: 20 (10 generated)
qyearsley@chromium.org changed reviewers: + dpranke@chromium.org
lgtm, though I would've left the line in but commented out.
The CQ bit was checked by qyearsley@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/12 at 18:54:56, dpranke wrote: > lgtm, though I would've left the line in but commented out. I was hesitating whether to do that -- I've heard advice before to never have commented-out code checked in to source control, since the original line can always be seen in the source control history. I think at this point we don't know whether we want to add this line back in the future, right?
On 2016/12/12 18:59:05, qyearsley wrote: > On 2016/12/12 at 18:54:56, dpranke wrote: > > lgtm, though I would've left the line in but commented out. > > I was hesitating whether to do that -- I've heard advice before to never have > commented-out code checked in to source control, since the original line can > always be seen in the source control history. > > I think at this point we don't know whether we want to add this line back in the > future, right? Actually in this case I'd probably like to add the line back in, but your concern is a good one so what you did wasn't particularly wrong :).
The CQ bit was unchecked by qyearsley@chromium.org
The CQ bit was checked by qyearsley@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by dpranke@chromium.org
Description was changed from ========== Stop logging the start of a run for individual layout tests. BUG=673207 ========== to ========== Stop logging the start of a run for individual layout tests. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=673207 ==========
The CQ bit was checked by dpranke@chromium.org
skipping the tryjobs for this since the tryserver is busted ...
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481579362166930,
"parent_rev": "57adccfc6e7d537e437e5a52ab4ada2fc4b44282", "commit_rev":
"c80ee3f777a777a422379ad20f95929866a89b9e"}
Message was sent while issue was closed.
Description was changed from ========== Stop logging the start of a run for individual layout tests. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=673207 ========== to ========== Stop logging the start of a run for individual layout tests. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=673207 Review-Url: https://codereview.chromium.org/2564343003 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Stop logging the start of a run for individual layout tests. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=673207 Review-Url: https://codereview.chromium.org/2564343003 ========== to ========== Stop logging the start of a run for individual layout tests. NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true BUG=673207 Committed: https://crrev.com/67aaccae4c80bb66c0a623a6e3e56b8151d6e3eb Cr-Commit-Position: refs/heads/master@{#437924} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/67aaccae4c80bb66c0a623a6e3e56b8151d6e3eb Cr-Commit-Position: refs/heads/master@{#437924} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
