Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 2564323003: Merged: [ic] Prevent KeyedStoreIC from being generic when storing doubles to integer typed arrays. (Closed)

Created:
4 years ago by Igor Sheludko
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.5
Project:
v8
Visibility:
Public.

Description

Merged: [ic] Prevent KeyedStoreIC from being generic when storing doubles to integer typed arrays. Revision: c819616376b6835b61ff4f9e2667ba94ab25fe7f BUG=chromium:666947, chromium:673137 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/fc0a0d7699c039df53961d47291981b151aba44f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -27 lines) Patch
M src/code-stub-assembler.h View 2 chunks +7 lines, -1 line 0 comments Download
M src/code-stub-assembler.cc View 5 chunks +135 lines, -26 lines 0 comments Download
M src/compiler/code-assembler.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Igor Sheludko
4 years ago (2016-12-12 08:35:56 UTC) #1
Igor Sheludko
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years ago (2016-12-12 08:35:59 UTC) #2
Benedikt Meurer
LGTM, thanks!
4 years ago (2016-12-12 08:39:09 UTC) #3
Michael Hablich
On 2016/12/12 08:39:09, Benedikt Meurer wrote: > LGTM, thanks! rubberstamp lgtm
4 years ago (2016-12-12 08:41:59 UTC) #5
Igor Sheludko
4 years ago (2016-12-12 08:44:56 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc0a0d7699c039df53961d47291981b151aba44f.

Powered by Google App Engine
This is Rietveld 408576698